search

pnp / List-Formatting

List Formatting Samples for use in SharePoint and Microsoft Lists
https://pnp.github.io/List-Formatting/
MIT License
1.7k stars 822 forks source link

Add second sample for library-highlight-non-empty-folders #768

Closed MoeIcI closed 5 months ago

MoeIcI commented 5 months ago
Q A
Bug fix? no
New sample? yes
Related issues? none

What's in this Pull Request?

I noticed that my first sample hides the buttons for sharing and to open the context menu. Therefore, I created a second version for this sample, which contains buttons that add the missing functions again.

screenshot_hidden_columns

MoeIcI commented 5 months ago

I'm sorry, but I accidentally added another directory with an old name of the sample(s).

tecchan1107 commented 5 months ago

Super cool update!!! Thank you @MoeIcI 🙏✨

However, there is one point of concern, and that is the shortcut to OneDrive. Someone using this sample might ask, "Why can't I create a shortcut to OneDrive when I click on it?" Therefore, if possible, could you please add a note in the README that customRowAction does not support shortcuts to OneDrive and that pressing the button does not create a shortcut. (Hopefully customRowAction will support this...😢)

tecchan1107 commented 5 months ago

Thank you for the fix and awesome sample @MoeIcI 🤩!!