search

pnp / PnP-PowerShell

SharePoint PnP PowerShell CmdLets
https://pnp.github.io/powershell
Other
985 stars 665 forks source link

Install-SharePointPnPPowerShell.ps1 does not have a "2019" option #2610

Closed joshtransient closed 4 years ago

joshtransient commented 4 years ago

Reporting an Issue or Missing Feature

When running the one-liner Invoke-Expression command from the PnP overview page on MS Docs, there is not an option to install the 2019 modules

Expected behavior

The confirmation prompt would ask to install Online, 2019, 2016, or 2013 modules

Actual behavior

The confirmation prompt currently asks to install Online, 2016, or 2013 modules

Steps to reproduce behavior

Run this command in a fresh PowerShell session (v3-v5.1), sourced from the PnP overview page on MS Docs

Invoke-Expression (New-Object Net.WebClient).DownloadString('https://raw.githubusercontent.com/sharepoint/PnP-PowerShell/master/Samples/Modules.Install/Install-SharePointPnPPowerShell.ps1')

Which version of the PnP-PowerShell Cmdlets are you using?

None, this would be for a fresh install of PnP PowerShell cmdlets without PowerShellGet installed, as documented by an MS Docs page

What is the version of the Cmdlet module you are running?

N/A, see above

How did you install the PnP-PowerShell Cmdlets?

N/A, see above

ghost commented 4 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

Markus-Hanisch commented 4 years ago

At @joshtransient I investigated which file needs to be modified. https://github.com/pnp/PnP-PowerShell/blob/master/Samples/Modules.Install/Install-SharePointPnPPowerShellHelperModule.ps1 However, I wait for @erwinvanhunen as he may left out this option on purpose?

KoenZomers commented 4 years ago

Fixed in the April 2020 release. Thanks @Markus-Hanisch for submitting your PR for this.