Get-PnPTenantTemplate: Fixing scope name generation - Githubissues

pnp / PnP-PowerShell

SharePoint PnP PowerShell CmdLets

https://pnp.github.io/powershell

Other

989 stars 662 forks source link

Get-PnPTenantTemplate: Fixing scope name generation #2874

Closed heinrich-ulbricht closed 4 years ago

heinrich-ulbricht commented 4 years ago

Type

[x] Bug Fix
[ ] New Feature
[ ] Sample

Related Issues?

N/A

What is in this Pull Request ?

While using Get-PnPTenantTemplate to extract a team I noticed that the scope names are sometimes incorrect. The following things happened:

the resource already contained the leading https:// resulting in a scope name starting with https://https://
the resource ended with / causing the scope name to end with ///.default

Sample error:

@erwinvanhunen And I replaced the // with / so right before the .default is always only one /.

Hope this makes sense. For me this fixed my problems.

erwinvanhunen commented 4 years ago

Thank you! While this should have been fixed on engine level already, an extra check doesn't hurt as such.