pnp / PnP-Sites-Core

Microsoft 365 Dev PnP Core component (.NET) targeted for increasing developer productivity with CSOM based solutions.
Other
417 stars 644 forks source link

Web Part background white in Page Section with Zone Emphasis #2254

Open bogeorge opened 5 years ago

bogeorge commented 5 years ago

Category

[ X ] Bug [ ] Enhancement

Environment

[ X ] Office 365 / SharePoint Online [ ] SharePoint 2016 [ ] SharePoint 2013

If SharePoint on-premises, what's exact CU version:

Expected or Desired Behavior

When applying a provisioning template to a ClientSidePage that is using the Background Emphasis for a Section the web parts should respect the background color.

Observed Behavior

When applying a provisioning template to a ClientSidePage that is using the Background Emphasis for a Section the web parts (NewsReel specifically) actually get a white background that overrides the section background color.

This appears to come from classes assigned to a DIV that has none in the original HTML.

Steps to Reproduce

This screen shows News with a white background (neutral) matching the section. The HTML on the right is highlighting a div that now has a class root-76 that is making the background white for the webpart overridding the section background DestinationHome

Additional Notes:

code

ghost commented 5 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

bogeorge commented 5 years ago

So I've discovered a little more on this that I wanted to share. I have another issue that the emphasis seems to be related to as well. The net seems to be that when using PnP to add the News web part a Newsreel with the wrong id is added. I affectionately have called this one the "old news". Old news likely doesn't support emphasis, which is why is has a white background instead of letting the section background through. New news however does allow the emphasis to shine through.

Check out Provisioned News web part is not filtering correctly base on the configured page property filter for more information like the ids, observations and a workaround for now if you are seeing this problem.