Move `m365 yammer` commands to `m365 viva engage`

[Aaron-Junker]

With the rebranding of Yammer to Viva Engage, the cli should also adapt and move all the m365 yammer commands under the m365 viva engage command.

If the team agrees, I would like to work on this issue.

[milanholemans]

If I remember it correctly we had an internal discussion about this a few months ago. I thought the conclusion was not to include it in the v7 release because it had a quite low priority and we had a load of other work for v7.

So I think we can definitely do this if we keep the original command as an alias so it's not a breaking change. Any objections @pnp/cli-for-microsoft-365-maintainers?

[Aaron-Junker]

@milanholemans When I try to run npm run build I always get this error message:

'/workspaces/cli-microsoft365/node_modules/@azure/msal-common/dist/index.cjs.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/azure__msal-common` if it exists or add a new declaration (.d.ts) file containing `declare module '@azure/msal-common';`

[milanholemans]

Odd, did you follow our guide on how to setup your local environment? https://pnp.github.io/cli-microsoft365/contribute/environment-setup#setting-up-your-local-project

[Aaron-Junker]

Odd, did you follow our guide on how to setup your local environment? https://pnp.github.io/cli-microsoft365/contribute/environment-setup#setting-up-your-local-project

Yes. NPM i shows no errors. I even tried in the Dev Container, same result.

[milanholemans]

Which version of Node are you using?

[Aaron-Junker]

Which version of Node are you using?

Node.js v18.18.2

[milanholemans]

Weird, could you check:

• You have the latest version of the code locally
• Run npm ci just to be sure and try again
• What typescript version is targeted?

[Aaron-Junker]

• Run npm ci just to be sure and try again

This worked. Weird.... Thank you!

[Aaron-Junker]

Another problem: Now no command works for every input I just get

CLI for Microsoft 365 v7.1.0
Manage Microsoft 365 and SharePoint Framework projects on any platform

[milanholemans]

What do you see if you run npm list -g --depth=0?

[Aaron-Junker]

@milanholemans

PS K:\cli-microsoft365> npm list -g --depth=0
C:\Users\aaron\AppData\Roaming\npm
├── @pnp/cli-microsoft365@7.1.0 -> .\K:\cli-microsoft365
├── docfx@1.0.5
├── generator-code@1.7.6
├── gulp-cli@2.3.0
├── npm@8.19.4
└── yo@4.3.1

[milanholemans]

Which shell are you using? PowerShell? Have you tried running it in another shell?

[Aaron-Junker]

Which shell are you using? PowerShell? Have you tried running it in another shell?

Yes. It's the same for command shell.

[milanholemans]

Well, it looks like the CLI cannot find any command for your build. Usually, this should work when the entire project is built. Running npm run clean and npm run build doesn't do anything?

[Aaron-Junker]

npm run clean

Now it's working. Thanks for your help.

[waldekmastykarz]

Resetting as available due to lack of response