Open milanholemans opened 6 months ago
I suggest that without wait we print the polling URL to console, just like we do for the external connection schema add command, in case folks want to poll manually.
For privacy, could we consider a reasonable default or should user always explicitly specify if they want a public or private community?
I suggest that without wait we print the polling URL to console, just like we do for the external connection schema add command, in case folks want to poll manually.
Ok, updated the specs.
For privacy, could we consider a reasonable default or should user always explicitly specify if they want a public or private community?
The API has no default value, you must provide one. I don't know which of the values we could consider default.
The challenge for this (and the get) command is that we currently have yammer group
commands which are not compatible with these new graph community commands. In my opinion, we should move all yammer group
commands to viva engage community
, and somehow try to make them compatible with each other however few commands use graph API and others use the yammer API.
I haven't compared the Yammer and Graph APIs so can't tell with certainty, but my gut feeling tells me that the data returned will be incompatible and we won't be able to move from Yammer to Graph APIs without introducing breaking changes.
I haven't compared the Yammer and Graph APIs so can't tell with certainty, but my gut feeling tells me that the data returned will be incompatible and we won't be able to move from Yammer to Graph APIs without introducing breaking changes.
Yes indeed, as discussed before, we'll just leave the group commands untouched and just introduce 2 new community
commands.
Yes indeed, as discussed before, we'll just leave the group commands untouched and just introduce 2 new
community
commands.
Thats a bit of a bummer but in the end I agree this is the best we may do for now to keep moving forward and we should consider 'refactoring' the existing yammer group
to Graph API for v8 (till end of year). We should create a separate issue for that.
other than that LGTM and lets open this one up 👍
Thats a bit of a bummer but in the end I agree this is the best we may do for now to keep moving forward and we should consider 'refactoring' the existing
yammer group
to Graph API for v8 (till end of year).
Not necessarily. We have other areas where we've got similar commands on Graph and SPO. As long as there's no parity, I think it's good to offer options as long as it's clear when to use which one.
Can I work on it?
Sure @Saurabh7019, thanks!
Usage
m365 viva engage community add [options]
Description
Creates a new community in Viva Engage
Options
--displayName <displayName>
--description <description>
--privacy <privacy>
public
, andprivate
.--adminEntraIds [ownerEntraIds]
adminEntraIds
oradminEntraUserNames
, but not both.--adminEntraUserNames [adminEntraUserNames]
adminEntraIds
oradminEntraUserNames
, but not both.--wait
Examples
Create a public community and wait for the community to be created
Create a private community
Default properties
No response
Additional Info
API
https://learn.microsoft.com/en-us/graph/api/employeeexperience-post-communities?view=graph-rest-beta&tabs=http
The API returns a URL which you can poll to check the status of the community. I suggest that without the
--wait
flag we just return nothing. When--wait
is specified, we return the community object on completion.Without
--wait
:With
--wait
:Remarks to be included in docs