pnp / cli-microsoft365

Manage Microsoft 365 and SharePoint Framework projects on any platform
https://aka.ms/cli-m365
MIT License
882 stars 312 forks source link

New command: `m365 spo folder sharinglink clear` #5965

Open MathijsVerbeeck opened 3 months ago

MathijsVerbeeck commented 3 months ago

Usage

m365 spo folder sharinglink clear [options]

Description

Removes all sharing links of a folder

Options

Option Description
-u, --webUrl <webUrl> The URL of the site where the file is located
--folderUrl [folderUrl] The server- or site-relative decoded URL of the folder. Specify either folderUrl or folderId but not both
--folderId [folderId] The unique ID (GUID) of the folder. Specify either folderUrl or folderId but not both
-s, --scope [scope] Scope of the sharing link. Possible options are: anonymous, users or organization. If not specified, all links will be removed.
-f, --force Don't prompt for confirmation

Examples

Removes a specific sharing link from a folder by id without prompting for confirmation

m365 spo folder sharinglink clear --webUrl https://contoso.sharepoint.com/sites/demo --folderId daebb04b-a773-4baa-b1d1-3625418e3234 --id 1 --confirm

Removes a specific sharing link from a folder by url with prompting for confirmation

m365 spo folder sharinglink clear --webUrl https://contoso.sharepoint.com/sites/demo --folderUrl /sites/demo/shared%20documents/Folder --id 1

Default properties

No response

Additional Info

No response

Adam-it commented 2 months ago

@pnp/cli-for-microsoft-365-maintainers anyone else up for 👀 on this 👍

MathijsVerbeeck commented 2 months ago
  • in the examples you refer to the remove command instead of clear

My bad

  • if I understand it properly if clear means removing all sharinglinks then why would we need the id option and why even make it required? Seems to me this option will allow to clear single sharinglink which is the same as the remove command right.

Again, too hasty

  • maybe the scope should also have an option all which will be just default. What is your take on that?

Why would we do that? We have it in quite a lot of commands that we simply use all when nothing is specified

  • also what @milanholemans pointed out in other issue - folderUrl should allow server and site-relative URLs

Changed that

Saurabh7019 commented 1 month ago

Can I work on it?

Adam-it commented 1 month ago

@Saurabh7019 the stage is yours 👍 You Rock 🤩