Open MathijsVerbeeck opened 3 months ago
you have a small glitch in -i, --id <id>]
it should be -i, --id <id>
without the ]
. Also I would write sharing link ID
instead of The ID of the sharing link
.
Besides that LGTM 👍
@pnp/cli-for-microsoft-365-maintainers anyone else for a 👀
My remarks:
Removes a sharing link of a folder
, I'd use Removes a sharing link from a folder
folderUrl
: should allow server and site-relative URLsfolderId
: unique ID are 2 wordsv2.1
SP REST API endpoint as much as possible, this to reduce the need for people to consent extra Microsoft Graph permissions on their app registration.The specs look good enough for me. Would you like to work on this @MathijsVerbeeck, or open it up?
You can open it up. I do still have some research however on how to retrieve the driveitemid from a folder, as this is not that straightforward as with a file. Should I post this procedure on every command (maybe add it in the specs)?
Can I take this as well? I will be working on the List command today.
All yours @Saurabh7019 . Thanks for your help!
Usage
m365 spo folder sharinglink remove [options]
Description
Removes a sharing link from a folder
Options
-u, --webUrl <webUrl>
--folderUrl [folderUrl]
folderUrl
orfolderId
but not both--folderId [folderId]
folderUrl
orfolderId
but not both-i, --id <id>
-f, --force
Examples
Removes a specific sharing link from a folder by id without prompting for confirmation
Removes a specific sharing link from a folder by url with prompting for confirmation
Default properties
No response
Additional Info
The API call to removea sharing link can be found on the following documentation: https://learn.microsoft.com/en-us/graph/api/permission-delete?view=graph-rest-1.0&tabs=http
Please try to use the SP REST API v2.1 as much as possible to reduce the need for extra Graph permissions.