Enhancement: `graph subscription add` allow subscription for Event Hubs and Event Grid

pnp / cli-microsoft365

Manage Microsoft 365 and SharePoint Framework projects on any platform

https://aka.ms/cli-m365

MIT License

887 stars 314 forks source link

Enhancement: `graph subscription add` allow subscription for Event Hubs and Event Grid #6050

Open MartinM85 opened 2 months ago

MartinM85 commented 2 months ago

The command graph subscription add has validation of notificationUrl that doesn't allow to create a subscription for notifications through Azure Event Hubs and Azure Event Grid.

To allow notifications through Azure Event Hubs and Azure Event Grid, modify the validator.

notificationUrl can start with

https://
EventHub:https://
EventGrid:?azuresubscriptionid

Adam-it commented 2 months ago

seems solid to me 👍💪 @pnp/cli-for-microsoft-365-maintainers anyone any other feed or should we open it up?

MartinM85 commented 2 months ago

I will take it