pnp / cli-microsoft365

Manage Microsoft 365 and SharePoint Framework projects on any platform
https://aka.ms/cli-m365
MIT License
904 stars 317 forks source link

New command: m365 spe container permission set #6160

Open Adam-it opened 1 month ago

Adam-it commented 1 month ago

Usage

m365 spe container permission set [options]

Description

Updates SharePoint Embedded Container permission

Options

Option Description
-i, --id <id> ID of the permission which will be modified.
--containerId <containerId> ID of the SharePoint Embedded Container.
-r, --roles <roles> Comma-separated list of permissions. Possible values are reader, writer, manager, owner.

Examples

Adds a reader role for the specified user to the container

m365 spe container permission set --containerId "b!ISJs1WRro0y0EWgkUYcktDa0mE8zSlFEqFzqRn70Zwp1CEtDEBZgQICPkRbil_5Z"  --id "cmVhZGVyX2k6MCMuZnxtZW1iZXJzaGlwfHJvcnlicjExMUBvdXRsb29rLmNvbQ" --roles "reader"

Default properties

No response

Additional Info

we may use the following API: https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-update-permissions?view=graph-rest-1.0&tabs=http

Jwaegebaert commented 1 month ago

It's similar to what I feel with the other container commands, but I find the description for containerId and permissionId a bit short and doesn't feel like it adds much of a description to the options.

Also -i, --containerId <id> should be -i, --containerId <containerId>

Adam-it commented 1 month ago

It's similar to what I feel with the other container commands, but I find the description for containerId and permissionId a bit short and doesn't feel like it adds much of a description to the options.

Also -i, --containerId <id> should be -i, --containerId <containerId>

ok I worked a bit on the descriptions ✅

Adam-it commented 1 month ago

@pnp/cli-for-microsoft-365-maintainers anything else or should we open it up?

milanholemans commented 1 month ago

Shouldn't it be named id instead of permissionId?

Adam-it commented 1 month ago

Shouldn't it be named id instead of permissionId?

good catch. updated ✅ anything else?