search

pnp / cli-microsoft365

Manage Microsoft 365 and SharePoint Framework projects on any platform
https://aka.ms/cli-m365
MIT License
920 stars 326 forks source link

New command: m365 spe container permission remove #6161

Open Adam-it opened 3 months ago

Adam-it commented 3 months ago

Usage

m365 spe container permission remove [options]

Description

Removes permissions from a SharePoint Embedded Container

Options

Option Description
-i, --id <id> ID of the permission to remove.
--containerId <containerId> ID of a SharePoint Embedded Container.
-f, --force [force] Don't prompt for confirmation.

Examples

Removes the specified permission from a container

m365 spe container permission remove --containerId "b!ISJs1WRro0y0EWgkUYcktDa0mE8zSlFEqFzqRn70Zwp1CEtDEBZgQICPkRbil_5Z"  --Id "cmVhZGVyX2k6MCMuZnxtZW1iZXJzaGlwfHJvcnlicjExMUBvdXRsb29rLmNvbQ"

Removes the specified permission from a container and doesn't prompt for confirmation

m365 spe container permission remove --containerId "b!ISJs1WRro0y0EWgkUYcktDa0mE8zSlFEqFzqRn70Zwp1CEtDEBZgQICPkRbil_5Z"  --Id "cmVhZGVyX2k6MCMuZnxtZW1iZXJzaGlwfHJvcnlicjExMUBvdXRsb29rLmNvbQ" --force

Default properties

No response

Additional Info

We may use the following API: https://learn.microsoft.com/en-us/graph/api/filestoragecontainer-delete-permissions?view=graph-rest-1.0&tabs=http

Adam-it commented 3 months ago

@milanholemans, @Jwaegebaert I applied similar changes from the comments I got from you in other spe commands. Do you see anything else? or should we open it up?

milanholemans commented 3 months ago

I made a few tiny changes, but LGTM 👍

milanholemans commented 3 months ago

Shouldn't it be named id instead of permissionId?

Adam-it commented 3 months ago

Shouldn't it be named id instead of permissionId?

aaa right. since permission is the object we are working on.. makes sense. I will update the spec

Adam-it commented 3 months ago

@milanholemans how about now?