pnp / cli-microsoft365

Manage Microsoft 365 and SharePoint Framework projects on any platform
https://aka.ms/cli-m365
MIT License
920 stars 325 forks source link

Enhance `spo listitem roleassignment` commands with Microsoft Entra groups #6195

Open milanholemans opened 3 months ago

milanholemans commented 3 months ago

Related to #6179


Let's extend command spo listitem roleassignment add and spo listitem roleassignment remove with 2 new options to add/remove Microsoft Entra groups.

Options Description
--entraGroupId [entraGroupId] ID of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...
--entraGroupName [entraGroupName] Display name of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...

Additionally, we should update the description of option --groupName [groupName] and make clear that this option is only used for SharePoint Online groups.


Todo:

ktskumar commented 1 month ago

May I work on this

Jwaegebaert commented 1 month ago

Hey @ktskumar, thank you for all the hard work you’ve put in, it’s really appreciated! We’ve noticed that you have several issues assigned that haven't yet been created with a PR. To ensure everyone has a chance to get involved, especially with Hacktoberfest, I’ll be unassigning you from some of these issues.

We recommend focusing on 1 to 2 issues at a time. Once you’ve submitted a PR for an issue, you can easily claim another open one. This approach helps you manage the workload more effectively and ensures you can give each task the attention it needs.

Thanks again for your continued contributions!

nicodecleyre commented 1 week ago

Hi,

Can i work on this one?