pnp / cli-microsoft365

Manage Microsoft 365 and SharePoint Framework projects on any platform
https://aka.ms/cli-m365
MIT License
920 stars 325 forks source link

Bug report: Cannot turn m365 setup registration from single into multitenant #6367

Closed StfBauer closed 4 weeks ago

StfBauer commented 1 month ago

Priority

(Medium) I'm annoyed but I'll live

Description

When the m365 setup gets executed the app registration is named 'CLI for Microsoft 365'. When this registration should be upgraded from single-tenant to multi tenant. The following error appears:

image

I was able to change the App Registration after I changed the name to 'CLI for M365'.

Steps to reproduce

  1. m365 setup
  2. https://learn.microsoft.com/en-us/entra/identity-platform/howto-convert-app-to-be-multi-tenant#update-registration-to-be-multitenant

Expected results

Different name for app registration name or let the user choose the name such "Pink fluffy unicorn".

Actual results

Like I said after I rename it to M365 instead of 'Microsoft 365' it worked.

Diagnostics

No response

CLI for Microsoft 365 version

9.0.0

nodejs version

v18.20.3

Operating system (environment)

macOS

Shell

bash

cli doctor

No response

Additional Info

No response

waldekmastykarz commented 1 month ago

Yeah, this is not great. Sorry we didn't catch it earlier. @pnp/cli-for-microsoft-365-maintainers any suggestions for an alternative app name that doesn't contain any restricted words?

milanholemans commented 1 month ago

Yeah, this is not great. Sorry we didn't catch it earlier. @pnp/cli-for-microsoft-365-maintainers any suggestions for an alternative app name that doesn't contain any restricted words?

Do we have a list of restricted words?

StfBauer commented 1 month ago

@waldekmastykarz not correct from a marketing perspective but changing the name to "CLI for M365" worked. Seems like "Microsoft 365" is the only blocked "word"

Adam-it commented 1 month ago

Yeah, this is not great. Sorry we didn't catch it earlier. @pnp/cli-for-microsoft-365-maintainers any suggestions for an alternative app name that doesn't contain any restricted words?

ye "PnP Management Shell (local)" 😂

I wonder if it is 'that smart' and we could use something like "CLI-for-Microsoft-365" 🤔 Will try to check this later on

MartinM85 commented 1 month ago

I think that the word Microsoft itself is restricted in the name of a multitenant app. Probably Azure too.

waldekmastykarz commented 1 month ago

I think that the word Microsoft itself is restricted in the name of a multitenant app. Probably Azure too.

Correct. I'm not sure if there's a publicly knows list of restricted words. That said, we should steer clear of any company and product names and should be good

milanholemans commented 1 month ago

If CLI for M365 works, that one will get my vote.

waldekmastykarz commented 1 month ago

Any other suggestions @pnp/cli-for-microsoft-365-maintainers?

waldekmastykarz commented 1 month ago

Let's go with CLI for M365