search

pnp / generator-teams

A Yeoman Generator for Microsoft Teams
https://pnp.github.io/generator-teams
MIT License
428 stars 112 forks source link

[U] Update node version, add node-prune dependency #333

Closed Boc-chi-no closed 1 year ago

Boc-chi-no commented 2 years ago

Update node version, add node-prune dependency

RickVanRousselt commented 2 years ago

Hi @LJea

Can you give some explanation what this change does? I like the move to node v16 because we needed that, but what does the node-prune do? Just willing to learn so if you can explain that would be super.

Boc-chi-no commented 2 years ago

The robot program I tried to build, some errors occurred, so I tried to upgrade the node version, but today I found that Node16 stopped Active Support today, and Security Support also stopped on September 11, 2023, maybe it should be more aggressively upgraded to the next an LTS version(Node 18) Because install.goreleaser.com is no longer accessible, I had to install node-prune using npm to make the program work and it helped me reduce node_modules size I had some problems installing node-prune I tried updating npm and node to make it work https://github.com/pnp/generator-teams/blob/main/packages/generator-teams/src/app/templates/Dockerfile#L3 https://github.com/pnp/generator-teams/blob/main/packages/generator-teams/src/app/templates/Dockerfile#L19

Boc-chi-no commented 1 year ago

The pull is outdated