pnp / graph-connectors-samples

Microsoft Graph Connector samples
https://aka.ms/gc/samples
MIT License
48 stars 35 forks source link

samples/nodejs-javascript-solutiongallery createConnection failed #22

Closed SchneidAIRGoogle closed 1 year ago

SchneidAIRGoogle commented 1 year ago

npm run createConnection failed

sample-solution-gallery-connector-node@1.0.0 createConnection node createConnection.js

Creating connection... TypeError: Cannot destructure property 'id' of 'config.connector' as it is undefined. at createConnection (file:///C:/Users/ksc.IPIWE/Downloads/pnp%20graph-connectors-samples%20main%20samples-nodejs-javascript-solutiongallery/createConnection.js:7:11) at main (file:///C:/Users/ksc.IPIWE/Downloads/pnp%20graph-connectors-samples%20main%20samples-nodejs-javascript-solutiongallery/createConnection.js:52:11) at file:///C:/Users/ksc.IPIWE/Downloads/pnp%20graph-connectors-samples%20main%20samples-nodejs-javascript-solutiongallery/createConnection.js:60:1 at ModuleJob.run (node:internal/modules/esm/module_job:194:25)

waldekmastykarz commented 1 year ago

Sorry to hear you're stuck @SchneidAIRGoogle and I appreciate you reaching out to us. What Node version are you using?

SchneidAIRGoogle commented 1 year ago

I am on Node.js v18.18.2 in PowerShell 7.3.8, dear @waldekmastykarz Should i try another verison?

waldekmastykarz commented 1 year ago

Let me try to see if I can repro it

waldekmastykarz commented 1 year ago

I can repro the issue. Sorry for that. I'll get it fixed right away and let you know when it's. So sorry for the trouble

waldekmastykarz commented 1 year ago

OK, the sample is fixed now. Once again, sorry for the trouble. Please, give it another shot and let us know if everything is working as intended

SchneidAIRGoogle commented 1 year ago

Wonderful, dear @waldekmastykarz. It is working now. i had to set the Adaptive Card in Result Type and configured a vertical with this new external Connecrion PnPCreateResultType PnPCreateVertical PnPIncludeConnectorResults PnPNewResultType PnPPowershell PnPSemplesMicrosoftSearch

waldekmastykarz commented 1 year ago

Brilliant! While the sample creates a result layout, it doesn't create a vertical because there are no APIs for it as far as I know. Awesome to see it working! How do you like it? Any other samples that you'd like to see?