Suggestion: View on GitHub - Open in new tab

pnp / m365-sample-gallery

Backend control and assets for the Microsoft 365 Sample Gallery - https://adoption.microsoft.com/sample-solution-gallery

https://adoption.microsoft.com/sample-solution-gallery

MIT License

20 stars 15 forks source link

Suggestion: View on GitHub - Open in new tab #18

Closed pkbullock closed 3 years ago

pkbullock commented 3 years ago

My preference would be to have the external links open in new tabs, if I were to check out multiple samples, I'm not a fan of being taken away from the site.

hugoabernier commented 3 years ago

Hey @pkbullock, while I'm a big fan of opening in a new tab (you should see how many tabs I have opened now!), the Web Accessibility Guidelines advise against opening in a new tab (see https://www.w3.org/TR/WCAG20-TECHS/G200.html).

I think the reasoning is that if people want to open in a new tab, they can CTRL-click or right-click -- as long as the "View on GitHub" is presented as an actual hyperlink, and not using an onclick event to open the link.

pkbullock commented 3 years ago

But SharePoint does it... 🤷‍♂️ - this can be closed.