Closed russgove closed 5 years ago
Hi Russel,
Below is the applied logic...essentially if we can't identify the page as webpartpage, wikipage, clientsidepage or publishingpage we assume it's a basic aspx page.
Can you check the list item fields for those pages? Can you edit these in SharePoint?
public static string PageType(this ListItem item)
{
if (FieldExistsAndUsed(item, Constants.HtmlFileTypeField) && !String.IsNullOrEmpty(item[Constants.HtmlFileTypeField].ToString()))
{
if (item[Constants.HtmlFileTypeField].ToString().Equals("SharePoint.WebPartPage.Document", StringComparison.InvariantCultureIgnoreCase))
{
return "WebPartPage";
}
}
if (FieldExistsAndUsed(item, Constants.WikiField) && !String.IsNullOrEmpty(item[Constants.WikiField].ToString()))
{
return "WikiPage";
}
if (FieldExistsAndUsed(item, Constants.ClientSideApplicationIdField) && item[Constants.ClientSideApplicationIdField].ToString().Equals(Constants.FeatureId_Web_ModernPage.ToString(), StringComparison.InvariantCultureIgnoreCase))
{
return "ClientSidePage";
}
if (FieldExists(item, Constants.PublishingRollupImageField) && FieldExists(item, Constants.AudienceField))
{
return "PublishingPage";
}
if (FieldExistsAndUsed(item, Constants.WikiField))
{
return "WikiPage";
}
return "AspxPage";
}
Hi Bert, I have 2 sample pages. Home.aspx cannot be transformed , Home2.aspx transforms just fine. I can edit both pages in the browser, however when I edit Home.aspx none of the webparts show, it's just showing me an empty wiki page to edit. they look the same when viewed in the libtrary:
Home.aspx is item #1 is the Site pages list. Home2.aspx is item 17
when I hit Web/Lists(guid'b4c8013a-d2d6-43b7-8658-7d04e71d993c')/Items(1) i get:
when I hit Web/Lists(guid'b4c8013a-d2d6-43b7-8658-7d04e71d993c')/Items(17) i get:
So Home.aspx has no wiki content.
These pages are being migrated from on prem using sharegate. I redid the migration of just that page and the edit experience in the browser worked properly. (i.e. when i edit the page i can see all the webparts).
When I run ConvertTo-PnPClientSidePage now i am getting:
@russgove : a page without wiki content should still be flagged as wiki page and result in an empty page. I'll open a bug to cross check that in the transformation engine (#22).
For the error after re-import via ShareGate: can provide me the field properties (like you did before with Web/Lists(guid'b4c8013a-d2d6-43b7-8658-7d04e71d993c')/Items(17)) and if possible the contents (html) from the wikifield?
Thanks bert, here it is: the full file is attached [image: image.png]
On Fri, Dec 21, 2018 at 2:29 AM Bert Jansen notifications@github.com wrote:
@russgove https://github.com/russgove : a page without wiki content should still be flagged as wiki page and result in an empty page. I'll open a bug to cross check that in the transformation engine (#22 https://github.com/SharePoint/sp-dev-modernization/issues/22).
For the error after re-import via ShareGate: can provide me the field properties (like you did before with Web/Lists(guid'b4c8013a-d2d6-43b7-8658-7d04e71d993c')/Items(17)) and if possible the contents (html) from the wikifield?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/21#issuecomment-449290476, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTRnBnrKneC-I21TC7piMi3iMZqyZQ4ks5u7I3AgaJpZM4Zcjbm .
File is not shown when attached as to mail. Can you paste the contents in here or alternatively send to me via email?
<?xml version="1.0" encoding="utf-8"?><entry xml:base="
https://tenantname.sharepoint.com/sites/sitename/_api/" xmlns="
http://www.w3.org/2005/Atom" xmlns:d="
http://schemas.microsoft.com/ado/2007/08/dataservices" xmlns:m="
http://schemas.microsoft.com/ado/2007/08/dataservices/metadata"
xmlns:georss="http://www.georss.org/georss" xmlns:gml="
http://www.opengis.net/gml"
m:etag=""42"">
</span></h2><span><p> </p></span><span><p>Add a new image, change this welcome text or add new lists to this page by clicking the edit button above. You can click on Shared Documents to add files or on the calendar to create new team events. Use the links in the getting started section to share your site and customize its look.
</p></span><span><p> </p></span></p></div></div><div data-sp-canvascontrol="" data-sp-canvasdataversion="1.0" data-sp-controldata="{"editorType":"CKEditor","controlType":4,"id":"b4ae81a2-1bea-4044-a482-b3b3259044b6","position":{"controlIndex":2.0,"zoneIndex":1.0,"sectionIndex":1,"sectionFactor":8}}"><div data-sp-rte=""><p><div><strong>Administration</strong><ul><li><a href="http://google.com">Administration Guide</a></li><li><a href="http://google.com">Core Brief</a></li><li><a href="http://google.com">Directions to Bentley Office</a></li><li><a href="http:// google.com">Helpdesk Quick Link</a></li><li><a href="http://google.com">Values and Behaviours - Bentley</a></li></ul></div><div><strong>Corporate</strong><ul><li><a href="http://google.com">sitename</a></li><li><a href="http://google.com">Vision Statement</a></li><li><a href="http:// google.com">Values and Behaviours</a></li><li><a href="http://google.com">Safety & Environment Legal Information</a></li><li><a href="http:// google.com">Safety, Health & Environment (SHE) Management Standards</a></li><li><a href="http:// google.com">Environmental Performance Standards</a></li><li><a href="http:// google.com">Safety Performance Standards</a></li></ul></div><div><strong>Bentley Business Plan</strong><ul><li><a href="http:// google.com">2011 Bentley Business Plan</a></li><li><a href="http://google.com">2012 Bentley Business Plan</a></li></ul></div><div><strong>Microsoft Office Training Modules</strong><ul><li><a href="http://google.com">Microsoft Office 2010 Training Modules</a></li></ul></div></p></div></div><div data-sp-canvascontrol="" data-sp-canvasdataversion="1.0" data-sp-controldata="{"editorType":"CKEditor","controlType":4,"id":"a827b7de-9c9e-4c8e-b4fc-a4d3c8e1c6e9","position":{"controlIndex":3.0,"zoneIndex":1.0,"sectionIndex":1,"sectionFactor":8}}"><div data-sp-rte=""><p><span><p> </p></span><span><p> </p></span><span><p> </p></span></p></div></div><div data-sp-canvascontrol="" data-sp-canvasdataversion="1.0" data-sp-controldata="{"editorType":"CKEditor","controlType":4,"id":"bd013094-aa98-45dc-b0c0-d7a149e41325","position":{"controlIndex":1.0,"zoneIndex":1.0,"sectionIndex":2,"sectionFactor":4}}"><div data-sp-rte=""><p><span class="fontColorThemeDarker"><p style="text-align:left;">
</p></span></p></div></div><div
data-sp-canvascontrol="" data-sp-canvasdataversion="1.0"
data-sp-controldata="{"webPartId":"d1d91016-032f-456d-98a4-721247c305e8","controlType":3,"id":"d0130bfa-6969-4684-9f26-cf2940a9d0c2","position":{"controlIndex":2.0,"zoneIndex":1.0,"sectionIndex":2,"sectionFactor":4}}"><div
data-sp-webpart="" data-sp-webpartdataversion="1.8"
data-sp-webpartdata="{"id":"d1d91016-032f-456d-98a4-721247c305e8","instanceId":"d0130bfa-6969-4684-9f26-cf2940a9d0c2","title":"Image","description":"Image","dataVersion":"1.8","properties":{"imageSourceType":2,"altText":"People
collaborating","fileName":"copmanynameBentley.png","siteId":"4f7ae9b5-ef91-4c7a-b319-6d03686f235b","webId":"b7309131-2020-4ca2-9308-5c0515f0abc3","listId":"b54b5a47-9c54-433f-b123-eb14a27962eb","uniqueId":"f87df8ff-6ed0-4c58-a82d-50e31ffa9804","useParallax":false}}"><div
data-sp-componentid="">d1d91016-032f-456d-98a4-721247c305e8</div><div
data-sp-htmlproperties=""><div data-sp-prop-name="captionText"
data-sp-searchableplaintext="true"></div><img
data-sp-prop-name="imageSource"
src="/sites/sitename/PublishingImages/copmanynameBentley.png"
/></div></div></div><div data-sp-canvascontrol=""
data-sp-canvasdataversion="1.0"
data-sp-controldata="{"editorType":"CKEditor","controlType":4,"id":"86f84d97-6443-4c4a-b6f6-339ffe9b2f02","position":{"controlIndex":3.0,"zoneIndex":1.0,"sectionIndex":2,"sectionFactor":4}}"><div
data-sp-rte=""><p><span><p> </p></span><span><p> </p></span></p></div></div><div
data-sp-canvascontrol="" data-sp-canvasdataversion="1.0"
data-sp-controldata="{"editorType":"CKEditor","controlType":4,"id":"6612b317-3337-4043-bc9b-85d764b9e214","position":{"controlIndex":4.0,"zoneIndex":1.0,"sectionIndex":2,"sectionFactor":4}}"><div
data-sp-rte=""><p><br><br></p></div></div><div
data-sp-canvascontrol="" data-sp-canvasdataversion="1.0"
data-sp-controldata="{"webPartId":"20745d7d-8581-4a6c-bf26-68279bc123fc","controlType":3,"id":"4472e4d2-dd60-4d71-913e-b40297ce3590","position":{"controlIndex":5.0,"zoneIndex":1.0,"sectionIndex":2,"sectionFactor":4}}"><div
data-sp-webpart="" data-sp-webpartdataversion="1.0"
data-sp-webpartdata="{"id":"20745d7d-8581-4a6c-bf26-68279bc123fc","instanceId":"4472e4d2-dd60-4d71-913e-b40297ce3590","title":"Events","description":"Events","dataVersion":"1.0","properties":{"selectedListId":"3741d188-4ef3-45ca-b73d-5bfcd56f27a9","selectedCategory":"","dateRangeOption":0,"startDate":"","endDate":"","isOnSeeAllPage":false,"layoutId":"FilmStrip","dataProviderId":"Event","webId":"b7309131-2020-4ca2-9308-5c0515f0abc3","siteId":"4f7ae9b5-ef91-4c7a-b319-6d03686f235b"}}"><div
data-sp-componentid="">20745d7d-8581-4a6c-bf26-68279bc123fc</div><div
data-sp-htmlproperties=""><div data-sp-prop-name="title"
data-sp-searchableplaintext="true"></div><a
data-sp-prop-name="baseUrl"
href="/sites/sitename"></a></div></div></div><div
data-sp-canvascontrol="" data-sp-canvasdataversion="1.0"
data-sp-controldata="{"editorType":"CKEditor","controlType":4,"id":"63f5dde4-21a1-4028-85a4-3856603426ea","position":{"controlIndex":6.0,"zoneIndex":1.0,"sectionIndex":2,"sectionFactor":4}}"><div
data-sp-rte=""><p><span><p> </p></span><span><p> </p></span><span><p> </p></span></p></div></div></div></d:CanvasContent1><d:BannerImageUrl
m:type="SP.FieldUrlValue">
On Fri, Dec 21, 2018 at 1:02 PM Bert Jansen notifications@github.com wrote:
File is not shown when attached as to mail. Can you pasted the contents in here or alternatively send to me via email?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/21#issuecomment-449457281, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTRnBWglSmHe_LWS5uQm0QF1btoT5Ewks5u7SImgaJpZM4Zcjbm .
CanvasContent1 and LayoutWebpartsContent are filled, this already is a modern page. Was this created by ShareGate? Somehow the ClientSideApplicationId field is not present, which is what I use to detect a modern page...looks really weird
Hi, yes it was created by sharegate. It was migrated from an on prem 2010 farm. It doesnt look modern to me (heres what i see when I edit the page: [image: image.png]
On Fri, Dec 21, 2018 at 2:48 PM Bert Jansen notifications@github.com wrote:
CanvasContent1 and LayoutWebpartsContent are filled, this already is a modern page. Was this created by ShareGate? Somehow the ClientSideApplicationId field is not present, which is what I use to detect a modern page...looks really weird
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/21#issuecomment-449482234, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTRnHlR5JQjZliGvz36WCoojO02QIy0ks5u7TsKgaJpZM4Zcjbm .
Ah, sharegate has a setting when migrating to 'Convert lists to modern experience'. I had that turned on. Let me turn it off and try again.....
On Fri, Dec 21, 2018 at 3:29 PM russell gove russellgove@gmail.com wrote:
Hi, yes it was created by sharegate. It was migrated from an on prem 2010 farm. It doesnt look modern to me (heres what i see when I edit the page: [image: image.png]
On Fri, Dec 21, 2018 at 2:48 PM Bert Jansen notifications@github.com wrote:
CanvasContent1 and LayoutWebpartsContent are filled, this already is a modern page. Was this created by ShareGate? Somehow the ClientSideApplicationId field is not present, which is what I use to detect a modern page...looks really weird
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/21#issuecomment-449482234, or mute the thread https://github.com/notifications/unsubscribe-auth/ACTRnHlR5JQjZliGvz36WCoojO02QIy0ks5u7TsKgaJpZM4Zcjbm .
OK , I tested with and without that setting. Sharegate seems to ALWAYs add CanvasContent1 and LayoutWebpartsContent
btw. Its sharegate v 9.0.2
Interesting...I checked the canvascontent1 field and clearly contains the html structure for a modern client side page...but somehow the ClientSideApplicationId field is not configured with the modern page feature id (=B6917CB1-93A0-4B97-A84D-7CF49975D4EC). Somehow someone experimented with this page resulting in an invalid setup...you could try with setting the ClientSideApplicationId field
Hi @russgove,
Any update on this one? It's interesting to understand how that page got created
Hi Bert, The page was migrated to spo from a 2010 on prem page using sharegate. I'm going to close this issue because we are not sure whether the site will be moved to SPO or another platform..
Hi, I'm getting this error when we tried doing the modern page conversion. we copied the pages/files from on-premises SP 2013 to SPO using ShareGate. we'd like to investigate this further to understand what could be done so that we can modernise the classic publishing pages to modern pages....
I'm also getting this as well on site pages that were migrated with ShareGate. Has there ever been a resolution or workaround for this? Thanks.
I am facing the same issue on multiple sites that we are trying to modernize, is there any solution about this topic?
Hi, Some pages in my Site Pages library give me the above error message others work fine. Looking at the page metadata I cant figure out what the difference is.
What causes this message?