Fix xslt list view definition with page transformation

krishnachaluvadi commented 5 years ago

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you. Thanks!

Problem Area

I was able to transform a classic page to modern page using PnP PowerShell Script. But on the modern page the list web part does not rendered as it was on classic page. For example, on classic page, I have a Contacts list (XSLT list view) with 2 columns, "Full Name", "Business Phone". After transforming to modern page, the list view rendered with all columns in the Contact list, like "Attachments, Last name, First name, Business Phone", and also shows the full tool tab or top with "New, Export To Excel", "All Items" (drop down to switch between views) and "See All" link. Same thing happened with Events list view web part.

[ ] Page Transformation: Error during the setup/use of the Page Transformation UI solution (did you check our troubleshooting guide?) [ ] Page Transformation: Error during the use of page transformation from PnP PowerShell [ ] Page Transformation: Error during the use of page transformation from .Net [x ] Page Transformation: Page is not looking correct after transformation [ ] Modernization Scanner: something went wrong...

Expected or Desired Behavior

Expected behavior is to add list view web part on the modern page same as on classic page. If not, is there any PnP script to access the modern page and detect the web part and modify view definition and publish the page.

Observed Behavior

I have a Contacts list (XSLT list view) with 2 columns, "Full Name", "Business Phone". After transforming to modern page, the list view rendered with all columns in the Contact list, like "Attachments, Last name, First name, Business Phone", and also shows the full tool tab or top with "New, Export To Excel", "All Items" (drop down to switch between views) and "See All" link. Same thing happened with Events list view web part. If you are reporting a bug, please describe the behavior you expected to occur when performing the action. If you are making a suggestion, you can delete this section.

Steps to Reproduce

Have a custom publishing page layout.
Have one or two list views (Contacts List, Events list, custom list with one or two columns showing)
Cross-site transformation of this classic publishing page to modern communication site.

PnP PowerShell Script used for transformation: ConvertTo-PnPClientSidePage -Identity pagename -PublishingPage -Overwrite -TargetWebUrl http://sourcesiteurl -PageLayoutMapping E:\custompagelayoutmapping.xml

jansenbe commented 5 years ago

Hi @krishnachaluvadi ,

When you do a cross site transformation the list view mapping requires that the same view (same query, same fields shown in the view and same rowlimit) is present in the target list in the communication site. The tool is not updating the lists in the target site as this tool only focuses on page transformation.

The toolbar setting should however be respected: if you've turned off the toolbar in the classic XSLT list view the modern List web part should also have the toolbar off. Note that the modern list web part only supports toolbar on/off, so not the intermediate model we have in the classic XSLT list view web part.

Are you testing this with a recent version?

krishnachaluvadi commented 5 years ago

Hi Bert, Appreciate your quick response. Yes, I understand that the page transformation focuses on transformation only. Please see below screen shots of my classic page, the way the list view web parts are placed and tool bar is turned off. What best can be done to fix this issue? Like any custom script to customize the view on modern page? I downloaded SharePointPnPPowerShellOnline.msi few days back, did not notice the version.

Classic Page: [image: image.png] Modern Page after transformation: [image: image.png]

On Fri, 2 Aug 2019 at 12:09, Bert Jansen notifications@github.com wrote:

Hi @krishnachaluvadi https://github.com/krishnachaluvadi ,

When you do a cross site transformation the list view mapping requires that the same view (same query, same fields shown in the view and same rowlimit) is present in the target list in the communication site. The tool is not updating the lists in the target site as this tool only focuses on page transformation.

The toolbar setting should however be respected: if you've turned off the toolbar in the classic XSLT list view the modern List web part should also have the toolbar off. Note that the modern list web part only supports toolbar on/off, so not the intermediate model we have in the classic XSLT list view web part.

Are you testing this with a recent version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/227?email_source=notifications&email_token=ACOSGT2WFLGW4O4TZBBCC2TQCRL2DA5CNFSM4II7AXEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OFYXA#issuecomment-517758044, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOSGT6TKXSFHRRRWLELBWDQCRL2DANCNFSM4II7AXEA .

-- Thanks & Regards Krishna Chaluvadi

jansenbe commented 5 years ago

Can you past the screenshots directly in GitHub? When you add them via a mail they're not showing up

krishnachaluvadi commented 5 years ago

Hi Bret, Another anomaly found is, the "Upcoming Events" list view web part is not open on the source classic page, but it was transformed and shown up on the page. Please refer to the modern page screen shot, top right corner, the web part shown. [image: image.png]

On Fri, 2 Aug 2019 at 12:43, Krishna krishnach78@gmail.com wrote:

Hi Bert, Appreciate your quick response. Yes, I understand that the page transformation focuses on transformation only. Please see below screen shots of my classic page, the way the list view web parts are placed and tool bar is turned off. What best can be done to fix this issue? Like any custom script to customize the view on modern page? I downloaded SharePointPnPPowerShellOnline.msi few days back, did not notice the version.

Classic Page: [image: image.png] Modern Page after transformation: [image: image.png]

On Fri, 2 Aug 2019 at 12:09, Bert Jansen notifications@github.com wrote:

Hi @krishnachaluvadi https://github.com/krishnachaluvadi ,

When you do a cross site transformation the list view mapping requires that the same view (same query, same fields shown in the view and same rowlimit) is present in the target list in the communication site. The tool is not updating the lists in the target site as this tool only focuses on page transformation.

The toolbar setting should however be respected: if you've turned off the toolbar in the classic XSLT list view the modern List web part should also have the toolbar off. Note that the modern list web part only supports toolbar on/off, so not the intermediate model we have in the classic XSLT list view web part.

Are you testing this with a recent version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/227?email_source=notifications&email_token=ACOSGT2WFLGW4O4TZBBCC2TQCRL2DA5CNFSM4II7AXEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OFYXA#issuecomment-517758044, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOSGT6TKXSFHRRRWLELBWDQCRL2DANCNFSM4II7AXEA .

-- Thanks & Regards Krishna Chaluvadi

-- Thanks & Regards Krishna Chaluvadi

krishnachaluvadi commented 5 years ago

Sure, will do that.

On Fri, 2 Aug 2019 at 13:15, Bert Jansen notifications@github.com wrote:

Can you past the screenshots directly in GitHub? When you add them via a mail they're not showing up

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SharePoint/sp-dev-modernization/issues/227?email_source=notifications&email_token=ACOSGT4ABGMWJUJGYCGQ5GLQCRTSJA5CNFSM4II7AXEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OK6SY#issuecomment-517779275, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOSGTZ3E5325IP7727VIKLQCRTSJANCNFSM4II7AXEA .

-- Thanks & Regards Krishna Chaluvadi

krishnachaluvadi commented 5 years ago

Classic Page - Please not that the "Contact Us" web part - I have not done the correct mapping, so it placed in down. Also not that there is no "Upcoming Events" list view on the page, it was closed.

Modern page after transformation:

jansenbe commented 5 years ago

Hi @krishnachaluvadi ,

Thanks for the details. I'll further look at this once I'm back from vacation but the fact that we migrate closed web parts is something we should fix (or make configurable). I'll create a separate issue for that.

Regarding the view, as we're not taking over the custom views you indeed need to create those yourselves. There are different options to do that:

Using 3rd party migration tools (ShareGate, Metalogix,AvePoint,...)
Using PnP PowerShell you can export the list definitions from the source site and apply those to the target site
Using remote API's you could programmatically do the same

3rd party migration tools or PnP PS are the easiest options in my view.

jansenbe commented 5 years ago

Hi @krishnachaluvadi ,

Since we've fixed the handling of closed web parts (#236) I'm going to close this issue. Regarding the list view you'll need to use 3rd party tooling or the PnP Provisioning engine to copy over the list with it's exact view definitions to the target site. Once the correct view is in the target it should get matched up. If that still isn't working at that point then please open a new issue.

pnp / modernization