search

pnp / modernization

All modernization tooling and guidance
http://aka.ms/sppnp-modernize
MIT License
156 stars 86 forks source link

Check need of WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING properties in Azure Function host #28

Closed jansenbe closed 5 years ago

jansenbe commented 5 years ago

See https://github.com/SharePoint/sp-dev-modernization/issues/27.

jansenbe commented 5 years ago

Might be related to different parameter needs for consumption plan vs general plan. See https://docs.microsoft.com/en-us/azure/azure-functions/functions-infrastructure-as-code and https://blog.siliconvalve.com/2018/05/03/multi-environment-deployments-for-compiled-c-azure-functions-with-vsts-release-management/

jansenbe commented 5 years ago

Root cause found: when you provide an already taken name for the storage account this error happens. Fix: add more validation in the script before executing

jansenbe commented 5 years ago

The needed checks are implemented. Closing this issue

jansenbe commented 5 years ago

There was one more reason for this issue: if you've used a character that's forbidden in a storage account name inside the function app name (e.g. uppercase character) then the WEBSITE_CONTENTSHARE property got populated with an invalid value. This will be fixed in the provisioning script.