search

pnp / modernization

All modernization tooling and guidance
http://aka.ms/sppnp-modernize
MIT License
156 stars 86 forks source link

Skip Asset transfer if asset exists #360

Closed pkbullock closed 5 years ago

pkbullock commented 5 years ago

Category

[ ] Bug [X] Enhancement

Problem Area

Performance

Expected or Desired Behavior

If the target site already contains an asset, e.g. you are overwriting transformed page, it isnt necessary to recopy up assets, for those environments with slow connections (like my test rig 😒)

jansenbe commented 5 years ago

well...you could use smaller files :-)

But, yes this should be optimized.

pkbullock commented 5 years ago

Yeah, not the highest priority one.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Bert Jansen notifications@github.com Sent: Friday, November 8, 2019 6:43:26 PM To: SharePoint/sp-dev-modernization sp-dev-modernization@noreply.github.com Cc: Paul Bullock paul.bullock@capacreative.co.uk; Assign assign@noreply.github.com Subject: Re: [SharePoint/sp-dev-modernization] Skip Asset transfer if asset exists (#360)

well...you could use smaller files :-)

But, yes this would be optimized.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSharePoint%2Fsp-dev-modernization%2Fissues%2F360%3Femail_source%3Dnotifications%26email_token%3DACC7Z4O7QJE4WINO65Q6O63QSWXM5A5CNFSM4JK4GDSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDTAAMY%23issuecomment-551944243&data=02%7C01%7Cpaul.bullock%40capacreative.co.uk%7C1ace4aa99b25420c41d308d7647b8afd%7Cb65b38dfdc4640ca92b9547172742753%7C0%7C0%7C637088354091403412&sdata=VLz54IdQqnteoGM%2FBFVKrIcNNtN6fuNDYtE%2B%2FriaHTE%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACC7Z4K76IWT2U4YDAMJLRTQSWXM5ANCNFSM4JK4GDSA&data=02%7C01%7Cpaul.bullock%40capacreative.co.uk%7C1ace4aa99b25420c41d308d7647b8afd%7Cb65b38dfdc4640ca92b9547172742753%7C0%7C0%7C637088354091403412&sdata=m3pzU8snlxEcifEXMTxYoKtuIG6LNKHDfoPmyRK7e1g%3D&reserved=0.

pkbullock commented 5 years ago

Closing this, i am using the ClearCache parameter, noticed in other transforms this is skipped.