search

pnp / pnpframework

PnP Framework is a .NET library targeting Microsoft 365 containing the PnP Provisioning engine and a ton of other useful extensions
https://pnp.github.io/pnpframework/
MIT License
211 stars 145 forks source link

Get-PnPSiteTemplate -PersistMultiLanguageResources can't create resource files #999

Open ez1003 opened 8 months ago

ez1003 commented 8 months ago

I ran the below commands to get a template file with resource files.

Connect-PnPOnline -Url "https://mytenant.sharepoint.com/sites/TemplateSite" -Interactive

Get-PnPSiteTEmplate -Out "Template.xml" -PersistBrandingFiles -IncludeAllPages -PersistMultiLanguageResources

I can have only Template.xml even though I used the option -PersistMultiLanguageResources. I could get Template.en-US.resx and Template.fr-FR.resx 10 days ago with a same command.

In the Template.xml, there's SupportedUILanguages but, there's still no resource files.

The PnP PowerShell versions I tried are: Manifest 2.4.23 nightly PnP.PowerShell Manifest 2.4.0 PnP.PowerShell
DanielMisch commented 7 months ago

Same here.

AndersRask commented 7 months ago

**This should be moved to PowerShell project

@KoenZomers @gautamdsheth it looks like resource generation is broken in current release. I can repro both on current release and on 2.3.61 nightly.

No resx file gets produced even though PersistMultiLanguageResources is specified. If you downgrade to lower versions (2.3.0) with exact same parameters it works fine.

jackpoz commented 2 months ago

I opened a pull request at https://github.com/pnp/powershell/pull/4326 to fix the issue.

jackpoz commented 1 month ago

The pull request has been merged so this issue should be solved.