search

pnp / pnpjs

Fluent JavaScript API for SharePoint and Microsoft Graph REST APIs
https://pnp.github.io/pnpjs/
Other
750 stars 306 forks source link

V4 OneNote (notes) #2894

Closed bcameron1231 closed 8 months ago

bcameron1231 commented 8 months ago

Category

What's in this Pull Request?

v4 implementation of OneNote

bcameron1231 commented 8 months ago

Needs review please.

Specifically how I handled the Combine<> within types.ts Using Omit<> and Pick<>, seems to remove the callable capability of the GraphQueryable objects. So I am using intersection types with the default response type such as _GraphCollection. Makes it callable and improves intellisense.

Additionally, the docs are a bit confusing. Graph docs have functionality interspersed between different sections. I grouped them slightly differently. Hopefully it makes sense.