search

pnp / pnpjs

Fluent JavaScript API for SharePoint and Microsoft Graph REST APIs
https://pnp.github.io/pnpjs/
Other
750 stars 306 forks source link

2895 - Rootweb fix #2896

Closed bcameron1231 closed 8 months ago

bcameron1231 commented 8 months ago

Current rebasing logic handles for /_api/site and /_api/web only. Any methods attached to rootweb eventually get truncated.

This adds a new /_api/site/rootweb regex test to rebase to.

Category

Related Issues

fixes #2895

What's in this Pull Request?

Update to Web to allow rebasing back to _api/site/rootweb Including a new test for ensureUser() on sites.ts test for continually verify this method works.

bcameron1231 commented 8 months ago

Potential Fix for this.

Please review, maybe there is a better approach for fixing this problem.

juliemturner commented 8 months ago

This seems correct to me, @allanhvam this will be in the v3 nightly build to be tested tomorrow.