pnp / pnpjs

Fluent JavaScript API for SharePoint and Microsoft Graph REST APIs
https://pnp.github.io/pnpjs/
Other
740 stars 300 forks source link

Next on cached pagination request #3034

Closed Kalshu closed 1 month ago

Kalshu commented 1 month ago

Major Version

3.x

Minor Version Number

24.0

Target environment

Browser App (Hosted external to Microsoft 365 platform)

Additional environment details

N/A

Expected or Desired Behavior

Get next on paged request from cache is not undefined

Observed Behavior

Get next on paged request from cache is undefined image

Steps to Reproduce

Make a call to retrieve the top 20 user from pnp lib /graph/users?$count=true&$top=20&$select=displayName%2cid%2cdepartment%2cjobTitle%2clocation%2cimageUrl%2cmail&$filter=accountEnabled+ne+false

Make a second call with same args to retrieve the request from the cache

In the result, next is not defined, but hasNext is true /graph/users?$count=true&$top=20&$select=displayName%2cid%2cdepartment%2cjobTitle%2clocation%2cimageUrl%2cmail&$filter=accountEnabled+ne+false

In 3.21 version, next is defined but return the result from cached request.

I will try to push a minimum env to reproduce this behaviors

bcameron1231 commented 1 month ago

Hi, Unfortunately we do not support pagination with caching. We did for a brief time with 3.21 but it had some negative side effects, so we had to revert it.

We may potentially bring it into version 4.

Duplicate of https://github.com/pnp/pnpjs/issues/2938

Kalshu commented 1 month ago

Thanks, for this quick response.

We will plan the migration to v4!

github-actions[bot] commented 1 month ago

This issue is locked for inactivity or age. If you have a related issue please open a new issue and reference this one. Closed issues are not tracked.