search

pnp / pnpjs

Fluent JavaScript API for SharePoint and Microsoft Graph REST APIs
https://pnp.github.io/pnpjs/
Other
753 stars 305 forks source link

Improved aliased parameter parsing #3084

Closed RoelVB closed 1 month ago

RoelVB commented 1 month ago

Category

Related Issues

fixes #3082

What's in this Pull Request?

This PR improves aliased parameter parsing, includes all sensible tests I could think of.

RoelVB commented 1 month ago

Am I correct to assume all tests with a dash (-) in front are skipped? Those are quite a few, including the new one

juliemturner commented 1 month ago

@RoelVB - I'm not sure what you mean... tests are skipped when they are declared it.skip(... or they use the this.skip() call in the test body.

RoelVB commented 1 month ago

@juliemturner Sorry for the very unclear comment. I mean this in the action: image Those "pending" include my new test