Open apprauHiruka opened 9 months ago
Hi @apprauHiruka,
Thank you for your submission! Your efforts are invaluable! During reviewing and attempting to compile from the source code, I encountered a few minor hitches that require attention prior to merging:
1) AI Education Teacher App issue: It appears that the 'Log in' button does not trigger any action. Upon investigation, it seems the 'OnSelect' property may not be configured properly. Could you please review and amend this?
2) AI Education issue:
While testing, the connector encountered an error (please refer to the attached screenshots for details). Could you please check if there are any prerequisites or certain parts of the source code that were overlooked?
3) During the compilation process, I received a warning:
Following root components are not defined in customizations:
Type='431', Id (or schema name)='GenericComponent-appr_course appr_courseicon'.
Type='432', Id (or schema name)='GenericComponent-appr_course'.
While this isn't blocking issue, addressing it could enhance the overall code quality.
I believe these adjustments are minor and am confident that they can be resolved swiftly. Once these issues are addressed, I will be more than happy to conduct a retest and proceed with merging your PR.
Thank you once again for your invaluable contribution and looking forward to your revised submission.
Kind regards, Katerina Chernevskaya
Hi @Katerina-Chernevskaya, Thank you for taking your valuable time to check the PR and letting me know about the issues. I'll look into those and fix them ASAP.
Cheers, Hiruka Ranasinghe
What's in this Pull Request?
Checklist