search

pnp / powerplatform-samples

The website for the PnP Power Platform samples gallery, including Power Apps, Power Automate, Power Virtual Agents, Portals, etc.
https://aka.ms/powerplatform-samples
MIT License
148 stars 137 forks source link

Rename the sample folder to power-365-crm #82

Open Power365initiatives opened 3 months ago

Power365initiatives commented 3 months ago

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <name@example.com>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Power365initiatives commented 3 months ago

Hi @Katerina-Chernevskaya

I've changed the name of the sample folder from Power365CRM to power-365-crm, I saw that all the files are in place including the files for both custom pages that are in the sales solution.

Power365initiatives commented 3 months ago

this is related with Pull request https://github.com/pnp/powerplatform-samples/pull/78, I've also followed the guidelines to add a contribution, could it be that I am missing a cli command that I need to execute?

Katerina-Chernevskaya commented 3 months ago

Hi @Power365initiatives,

Thank you for updating! I tried to generate the solution from the source code for the Sales Solution and dot the error again: image I used your new branch https://github.com/Power365initiatives/powerplatform-samples/tree/Power-365-crm. Please check again and make sure that all required components are in place. Also please remove one of the PR and keep just one for the solution.

Thank you!

Regards, Katerina Ch.