[BUG] Viva Connections creates a second pages library, breaking site pages detection - Githubissues

pnp / powershell

PnP PowerShell

https://pnp.github.io/powershell

MIT License

672 stars 344 forks source link

[BUG] Viva Connections creates a second pages library, breaking site pages detection #3710

Closed nils-a closed 8 months ago

nils-a commented 8 months ago

Expected behavior

The PagesUtility contains code to find the "site pages" library. I would expect this code to find the "site pages".

Actual behavior

This code might fail or target the wrong library, for sites that have Viva connections created "Announcements" library.

Steps to reproduce behavior

The same or similar code was modified in https://github.com/pnp/pnpframework/pull/975/ and https://github.com/pnp/pnpcore/commit/0ea1c82c04342754a64881f5c6b01f8ba579efbf

What is the version of the Cmdlet module you are running?

I looked at the current version: https://github.com/pnp/powershell/blob/44827da6c9fb671104948778f39e8eab0e5b6442/src/Commands/Utilities/PagesUtility.cs#L30-L34

Which operating system/environment are you running PnP PowerShell on?

[ ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

gautamdsheth commented 8 months ago

Hi @nils-a , have fixed this. It was used in Enable/Disable-PnPPageScheduling cmdlets. Will be available in tomorrow's nightly builds.

Thanks for raising the issue and sharing the fix with us.