Fix for bug in PR #4262

wuxiaojun514 commented 2 weeks ago

Type

[x] Bug Fix
[ ] New Feature
[ ] Sample

Related Issues?

Fixes #4255 I created a PR #4262 before, but I found this PR doesn't really fix the bug, it just doesn't show the error message anymore. So I created this new PR to fix bug in #4262

What is in this Pull Request ?

Restore-PnPListItemVersion command still doesn't work properly if multiple fields change (including taxonomy field) need to be restored. The previous hotfix just avoid error message, it doesn't really solve the issue. As I tested , CSOM cannot mix set list item value with query list field together. So I changed a bit on this command to query list field first, then set list item value later to avoid conflict.

Guidance

You can delete this section when you are submitting the pull request.*
Please update this PR information accordingly. We use this as part of our release notes in monthly communications.
Please target your PR to Dev branch. If you do not target the Dev branch we will not accept this PR.

wuxiaojun514 commented 2 weeks ago

I saw the build failed, actually I also got this build issue (cannot convert from 'System.Security.SecureString' to 'string') when I pulled the latest code from dev branch. The problem is in authentication module. I just submitted code related with Restore-PnPListItemVersion

wuxiaojun514 commented 2 weeks ago

The root cause for build failure is due to PnP.Framework library, I tried to change nuget package to its two days ago version and I don't get compile issue. PnP.Framework changed a lot on authentication recently Removed references to the PnP Management Shell app

gautamdsheth commented 2 weeks ago

Hi @wuxiaojun514 , have fixed this build issue. Will review the PR shortly.

pnp / powershell