pnp / powershell

PnP PowerShell
https://pnp.github.io/powershell
MIT License
673 stars 346 forks source link

[BUG] Latest version in version check is nightly and not stable one #4408

Open tivanchuk-hawe opened 1 week ago

tivanchuk-hawe commented 1 week ago

Reporting an Issue or Missing Feature

In latest stable release https://github.com/pnp/powershell/releases/tag/v2.12.0 was changed "Removed version check dependency on version.txt located in Github repo. Use metadata from powershellgallery.com instead." This is OK, but now (unlike previously, check the version history) there are nightly versions in PS Gallery, so when you check there the latest version it shows nightly one. image

Possible solutions as I see them: (either or)

  1. use prerelease for nightly + update check ignores alpha, beta ones
  2. Nightly isn't posted in PS Gallery anymore => check will work as expected after the next stable release
  3. If you keep posting nightly in PS Gallery w/o 1st - probably the check should be changed back

Expected behavior

Nightly isn't shown on new version check

Actual behavior

Update check shows latest nightly version

Steps to reproduce behavior

  1. Installed 2.12.0
  2. Connect-PnPOnline
  3. warning will shown

What is the version of the Cmdlet module you are running?

2.12.0

Which operating system/environment are you running PnP PowerShell on?

ddouden commented 1 week ago

Same issue here, running the stable version. @erwinvanhunen On PSGallery the 2.99.8-nightly version is shown as the current version.

https://www.powershellgallery.com/packages/PnP.PowerShell/2.99.8-nightly

KoenZomers commented 1 week ago

Correct. I can reproduce this and found the issue. Thanks for reporting it.