pnp / powershell

PnP PowerShell
https://pnp.github.io/powershell
MIT License
623 stars 329 forks source link

Export-PnPTaxonomy extra option needed: -IncludeDeprecated [FEATURE] #532

Open prossum opened 3 years ago

prossum commented 3 years ago

Is your feature request related to a problem? Please describe. While using Export-PnPTaxonomy I get also the deprecated terms. I like to filter on this property.

Describe the solution you'd like Export-PnPTaxonomy -TermSetId -Path -IncludeDeprecated $false

Describe alternatives you've considered The available alternative is to download the whole TermGroup as XML and do the selection myself.

Additional context n/a

sankarkumar23 commented 1 year ago

I've created a PR for this feature. Please review.

markgort86 commented 3 weeks ago

@sankarkumar23 you need to make a Pull Request to the main branch to provide this code to the PnP PowerShell repository. It looks like you only pushed it to you're own branch. Could you have a look on this?

See also: https://pnp.github.io/powershell/articles/gettingstartedcontributing.html#submitting-your-changes-for-review

sankarkumar23 commented 2 weeks ago

Thanks for reaching out. I've very limited knowledge on GitHub and did not know the process. I created a new PR now.. here is my link https://github.com/pnp/powershell/pull/4053. Appreciate if you can guide me with next steps.

markgort86 commented 2 weeks ago

You're PR is now visible for the repo owners to provide feedback on this.

Let's see if this can be merged.. or that you need to provide some changes on the code or description.