pnp / provision-assist-m365

Provision Assist is a request and provisioning solution for Teams, Groups, SPO Sites and Viva Engage Communities in Microsoft 365. It can be used as part of a Copilot for Microsoft 365 deployment.
MIT License
62 stars 9 forks source link

UI bug: Border of collab space choosing screen is changing when using translated labels #57

Open wapster182 opened 8 months ago

wapster182 commented 8 months ago

Description

When using translated labels, the UI border of collab space choosing screen is changing.

Using original labels (en): image

Using translated labels (de): image

Steps to reproduce

  1. Translate labels
  2. Paste the .json into the component
  3. Launch app with browser setting of tranlated labels
  4. Progress to Step 2 Recommendation screen

Expected results

UI border should not be affected by translated labels and look the same.

Actual Results

UI border should is affected by translated labels and does not look the same.

Solution component

Power App

Operating system (environment)

Windows

Additional Info

No response

alexc-MSFT commented 8 months ago

@wapster182 thanks for reporting this. We will get it fixed.

Thanks

alexc-MSFT commented 8 months ago

@wapster182 please can you send me your DE JSON so I can test as we only have NL and EN at the moment so a copy of yours would be helpful. Thanks

alexc-MSFT commented 8 months ago

@wapster182 please could you also send me the text you are using for the provisioning types too please (in case it is that which is causing the issue). Thanks

wapster182 commented 8 months ago

Hi Alex, I have attached our json including the german localization (DE). The text that we are using for the provisioning types description is included there, however I have it extracted here:

"Teams ist eine kollaborative Kommunikationsinfrastruktur, die Chats, Videokonferenzen, Sprachanrufe, Dokumente und Dateien eines Teams organisiert."

It seems the name of the type (e.g. "Microsoft Teams Team") is not part of the localization. It is also identical to the english one on the screenshot.

TranslationsProvisionAssist.json

alexc-MSFT commented 8 months ago

@wapster182 I'm unable to replicate this, which is very strange, does it happen every time?

What screen resolution are you using?

Thanks

image

wapster182 commented 8 months ago

Hi, I tried different solutions (1080p, 1200p, 1440p, directly in Teams) but it does not make a difference. Is your Power Platform environment somehow different from the "standard" one? Because it looks a little different with the not pink bar and the top. Here is a full screenshot: image

However, the UI bug is not that bad so we could accept it for now, would you be able to release the new version with the other new functions soon?

alexc-MSFT commented 8 months ago

@wapster182 ok, I'll keep the issue open, I didn't test embedded in Teams so there may be an issue there.