pnp / provision-assist-m365

Provision Assist is a request and provisioning solution for Teams, Groups, SPO Sites and Viva Engage Communities in Microsoft 365.
MIT License
52 stars 5 forks source link

Still issue with external sharing #74

Open Tarre86 opened 4 months ago

Tarre86 commented 4 months ago

Description

Hi! We cant still get external sharing to work. It looks like this when we have it "on". image image image image image

Steps to reproduce

1.Tried several times 2. 3.

Expected results

To share links for Sharpoint sites

Actual Results

Not working

Solution component

Logic Apps

Operating system (environment)

Windows

Additional Info

No response

alexc-MSFT commented 4 months ago

@Tarre86 how did you change the name of the 'Space type', just checking you changed the Title column in the Provisioning Types list?

Can you edit the logic app and double check what the condition is please, it should be -

image

Thanks

Tarre86 commented 4 months ago

@Tarre86 how did you change the name of the 'Space type', just checking you changed the Title column in the Provisioning Types list?

Can you edit the logic app and double check what the condition is please, it should be -

image

Thanks

I changed just name under the "Title" in the provisioning types list. image Under the logic app it looks the same. image

alexc-MSFT commented 4 months ago

@Tarre86 ok this is a bug which I have just fixed, I can walk you through how to do it manually -

  1. Edit the ProcessProvisionRequest Logic App and locate the 'Configure Space' action
  2. In the Runbook Parameter 'externalsharing' remove the existing dynamic content value and select 'External Sharing Required' in the dynamic content pane from the 'When an item is created' action
  3. Save the logic app
  4. Locate the 'ConfigureSpace' runbook in the automation account and edit it
  5. Update line 95 to read 'If ($externalSharing.ToLower() -eq "True") {'
  6. Publish the runbook

Please then reattempt to provsion an SPO site and see if sharing is enabled properly.

I'll also make the fix in the repo shortly.

Tarre86 commented 4 months ago

@Tarre86 ok this is a bug which I have just fixed, I can walk you through how to do it manually -

  1. Edit the ProcessProvisionRequest Logic App and locate the 'Configure Space' action
  2. In the Runbook Parameter 'externalsharing' remove the existing dynamic content value and select 'External Sharing Required' in the dynamic content pane from the 'When an item is created' action
  3. Save the logic app
  4. Locate the 'ConfigureSpace' runbook in the automation account and edit it
  5. Update line 95 to read 'If ($externalSharing.ToLower() -eq "True") {'
  6. Publish the runbook

Please then reattempt to provsion an SPO site and see if sharing is enabled properly.

I'll also make the fix in the repo shortly.

Thank for quick reply. Same issue with the sharing but this one is working. image And the setting that you mentioned before looks like this. image image Then the actual test request looks like this in ProcessProvisionRequest image

Best Regards

alexc-MSFT commented 4 months ago

@Tarre86 sorry I've just realised the line in the script should be:

I.e. true in lowercase

If ($externalSharing.ToLower() -eq "true") {

Please try that

Tarre86 commented 4 months ago

@Tarre86 sorry I've just realised the line in the script should be:

I.e. true in lowercase

If ($externalSharing.ToLower() -eq "true") {

Please try that

Same issue unfortunately...