pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
109 stars 92 forks source link

Contributing new SPFx ACEs sample for the first time #117

Closed MaheeTech closed 1 year ago

MaheeTech commented 1 year ago

This pull request includes new ACEs card which is ApplyLeave card with a feature set out of office and also this card shows leave history where user can configure to view a My Holiday Card in Dashboard page.

This PR includes two ACEs, first card (ApplyLeave & Set out of office Card) talks about how to submit a leave and in parallel user can set out of office message for that duration. Second card (My Holidays) talks about list of holidays for the selected country.

dcashpeterson commented 1 year ago

@MaheeTech Thank you for your submission. I was reviewing this release and it doesn't look like the appropriate graph permissions are included in the package-solution.json file. If you could please add those then I can retest. If you need assistance please see this reference. https://learn.microsoft.com/en-us/sharepoint/dev/spfx/use-aad-tutorial#configure-the-api-permissions-requests

MaheeTech commented 1 year ago

@dcashpeterson thank you.. I added API permission in package-solution.json file....

dcashpeterson commented 1 year ago

@MaheeTech Can you please check the instructions in the readme? I created the list and it is writing content into the list but it is throwing an error that it's looking for a Status column that isn't in the list or in the instruction.

MaheeTech commented 1 year ago

@dcashpeterson I added required changes in README file... thank you for your time in reviewing the code....

dcashpeterson commented 1 year ago

@MaheeTech When you have a minute can you please reach out to me on twitter? I have some questions about this sample.

dcashpeterson commented 1 year ago

Closed due to inactivity. If you would still like to submit this sample we would love to have it. Please fix the issues we discussed and resubmit it.