search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
109 stars 92 forks source link

PublicHolidaysAdaptiveCardExtension: is not initialized #122

Closed blueitpro closed 1 year ago

blueitpro commented 1 year ago

ImageCard-PublicHolidays

Authors

@nanddeepn @ravi16a87 @SmitaNachan

Expected or Desired Behavior

Display Public Holidays

Observed Behavior

at t._getRenderArguments (https://res-1.cdn.office.net/files/sp-client/sp-adaptive-card-extension-base_en-us_2856abecc053ce38a08e.js:1:29486) at t.update (https://res-1.cdn.office.net/files/sp-client/sp-adaptive-card-extension-base_en-us_2856abecc053ce38a08e.js:1:29187) at t._navigatorCallback [as _handleStackChangedCallback] (https://res-1.cdn.office.net/files/sp-client/sp-adaptive-card-extension-base_en-us_2856abecc053ce38a08e.js:1:23744) at e.replace (https://res-1.cdn.office.net/files/sp-client/sp-adaptive-card-extension-base_en-us_2856abecc053ce38a08e.js:1:20109)

at t. (https://tenant.sharepoint.com/sites/Apps/ClientSideAssets/d19e1ab6-ebe7-4abb-92a5-e6ba9cfc370d/public-holidays-adaptive-card-extension_9a977e6d0b5d976a07b5.js:2:79637) at https://tenant.sharepoint.com/sites/Apps/ClientSideAssets/d19e1ab6-ebe7-4abb-92a5-e6ba9cfc370d/public-holidays-adaptive-card-extension_9a977e6d0b5d976a07b5.js:2:78234 at Object.next (https://tenant.sharepoint.com/sites/Apps/ClientSideAssets/d19e1ab6-ebe7-4abb-92a5-e6ba9cfc370d/public-holidays-adaptive-card-extension_9a977e6d0b5d976a07b5.js:2:78339) at https://tenant.sharepoint.com/sites/Apps/ClientSideAssets/d19e1ab6-ebe7-4abb-92a5-e6ba9cfc370d/public-holidays-adaptive-card-extension_9a977e6d0b5d976a07b5.js:2:77275 at new Promise () at st (https://tenant.sharepoint.com/sites/Apps/ClientSideAssets/d19e1ab6-ebe7-4abb-92a5-e6ba9cfc370d/public-holidays-adaptive-card-extension_9a977e6d0b5d976a07b5.js:2:77023)

Environment Details (Development & Target environment)

nanddeepn commented 1 year ago

Hi @blueitpro Thank you for reporting. I will have a look and fix.

nanddeepn commented 1 year ago

Hi @blueitpro PR is raised at https://github.com/pnp/sp-dev-fx-aces/pull/123. It should be merged soon.

blueitpro commented 1 year ago

@nanddeepn Thank you for the fix, when can we expect this to be available?

nanddeepn commented 1 year ago

Thank you @blueitpro The Repo maintainer @dcashpeterson will review and merge the PR soon.

nanddeepn commented 1 year ago

Thank you @dcashpeterson ❤️

hsantan commented 1 year ago

sppkg published doesn't have the fixed version. Can you publish the new version?

nanddeepn commented 1 year ago

Hi @hsantan This issue is closed. Can you please create a new one here? Thank you.