search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
111 stars 93 forks source link

Three new code samples - library loans, Book a space and scholarships. #139

Closed jesegher closed 1 year ago

jesegher commented 1 year ago

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

Q A
Bug fix? no
New feature? yes
New sample? yes
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed. Two new code samples were added. Library loans and Scholarships.

Submitter Guidance (DELETE AFTER READING)

jesegher commented 1 year ago

Three new code samples. Library Loans and scholarships were submitted already. Added book a space on 5/18.

jesegher commented 1 year ago

@dcashpeterson I know you merged the first request. I was wondering if you could do the same for this one?

jesegher commented 1 year ago

Update sample.json in bookspaces.

dcashpeterson commented 1 year ago

@dcashpeterson I know you merged the first request. I was wondering if you could do the same for this one?

@jesegher I will do my best to get to this soon.

jesegher commented 1 year ago

@dcashpeterson I know you merged the first request. I was wondering if you could do the same for this one?

@jesegher I will do my best to get to this soon.

@dcashpeterson I chatted with Vesa and he will merge it tomorrow. thank you though.