search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
109 stars 92 forks source link

[PrimaryTextCard-PlannerTasks]: [getPlanInfo is giving 404 error] #146

Closed PanchamiM closed 12 months ago

PanchamiM commented 1 year ago

Adaptive Card: PrimaryTextCard-PlannerTasks Issue: After getting all the tasks from graph api, for each task we are getting plan name and it is erroring out for some users. Error: 404 Completer Error Log: {"statusCode":404,"code":"","message":"The requested item is not found.","requestId":"","date":"2023-06-29T09:44:29.000Z","body":"{\"code\":\"\",\"message\":\"The requested item is not found.\",\"innerError\":{\"date\":\"2023-06-29T11:44:29\",\"request-id\":\"\",\"client-request-id\":\"\"}}"} Environment: Production Method Name: public async getPlanInfo(planId: string): Promise { File name where method is : GraphService.ts Behaviour: The issue is intermediate Error

dcashpeterson commented 1 year ago

@PanchamiM did you check and make sure that the graph permissions were granted in the api admin center?

PanchamiM commented 1 year ago

@dcashpeterson yes the permissions are assigned. It is working for majority of users. But some users are facing this issue.

PanchamiM commented 1 year ago

Any update on this.

PanchamiM commented 1 year ago

Any update on this.

PanchamiM commented 1 year ago

This issue is being observed in Prod. Please anyone has any idea on this.

anoopt commented 1 year ago

Hi @PanchamiM - Just wanted to confirm if you have consented the permissions as per the instructions? - https://github.com/pnp/sp-dev-fx-aces/tree/main/samples/PrimaryTextCard-PlannerTasks#prerequisites

Also can you please take a look at this short video which shows the demo of the sample to see if find any relevant information? - https://www.youtube.com/watch?v=_1WNf4-GZiY&ab_channel=Microsoft365%26PowerPlatformCommunity

PanchamiM commented 1 year ago

Hi @anoopt Below are the permissions assigned in the admin center. Tasks.Read Tasks.ReadWrite Group.ReadWrite.All

This should be fine right?

anoopt commented 1 year ago

Yes.

When the users (or you) open to the planner (https://tasks.office.com) do the they see the plan (that is configured in the ACE properties - Select Planner plan) ?

PanchamiM commented 1 year ago

By default we have set the All Plans options.

anoopt commented 1 year ago

Ok @PanchamiM . I am not able to replicate this issue in my tenant. So can you please confirm if users are able to access the planner from https://tasks.office.com?

PanchamiM commented 1 year ago

@anoopt yes I am able to open the Planner from the give URL. This is not happening to all users, only some of the users are facing it and it is intermediate.

PanchamiM commented 1 year ago

Any update on this.

dcashpeterson commented 1 year ago

@PanchamiM we have both tried to reproduce this without success. Can you consistently replication this with specific users?

I have taken a look at the code and the error in question is happening because there is a collection of tasks coming back from either the '/me/planner/tasks' endpoint or the '/planner/plans/${planId}/tasks' endpoint.

Is the ACE configured with a plan ID or without a plan ID?

For users where this is not working, can you work with them to access the graph explorer and if the ACE does not have a plan ID then see what is returned from the /me/planner/tasks endpoint or if there is a plan ID then the /planner/plans/${planId}/tasks endpoint and share the results from that. The issue is that either there are tasks that are not associated with a plan OR that the user has a task assigned to them but they don't have access to the plan the task is part. That is my best guess.

PanchamiM commented 1 year ago

@dcashpeterson The Ace is not configured with any plan ID. It is supposed to query all the tasks. As per my understanding and the way I tested in dev environment whenever a user is added to a task they will be given the access to the Plan also. The users are from client side and it will be difficult to connect with them. Anyway I will check if we can get anything.

PanchamiM commented 1 year ago

We cannot connect with the clients. Any breakthrough in this?

dcashpeterson commented 12 months ago

@PanchamiM without more information we can't provide any more guidance. This looks like an issue with permissions of some sort so without actually reproducible steps or access to info from the users we can't provide any more assistance. I am going to go ahead and close this issue. If you get more info from the users or can provide us with reproducible steps please open a new issue and reference this one.