search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
112 stars 96 forks source link

Added new sample MyEmails #21

Closed siddharth-vaghasia closed 2 years ago

siddharth-vaghasia commented 2 years ago
Q A
New sample? yes

What's in this Pull Request?

Added new sample ACE for showing current user's emails in ACEs

dcashpeterson commented 2 years ago

@siddharth-vaghasia thank you for your sample. I am in the process of reviewing it and will get it approved as soon as I can. Question, the ReadMe indicates that this is targeted to 1.13 but the package.json uses 1.14 beta. Do you want to pick one and update? Thanks again!

siddharth-vaghasia commented 2 years ago

@dcashpeterson - sure, will update.

siddharth-vaghasia commented 2 years ago

if you can please advise on what the should be a badge for the 1.14 beta? Tried some combinations but it not worked...

or it would be https://img.shields.io/badge/version-1.14.0-green.svg ?

dcashpeterson commented 2 years ago

@siddharth-vaghasia go ahead and use the 1.14.0-green. I can check with folks and make sure it's correct and if it's the only change I can update it later if it's incorrect.

siddharth-vaghasia commented 2 years ago

@dcashpeterson - I have updated to spfx 1.14....

dcashpeterson commented 2 years ago

@siddharth-vaghasia Thank you for the sample. I apologize it took me so long. @PopWarner will reach out to set up a demo if he hasn't already.