search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
112 stars 96 forks source link

Primary text card people details #27

Closed XLR8-0 closed 2 years ago

XLR8-0 commented 2 years ago
Q A
Bug fix? no
New feature? no
New sample? yes

What's in this Pull Request?

This Adaptive Card Extension shows general CRUD operations for people details using SharePoint list and Adaptive Card which involves multiple QuickViews and pnp js.

dcashpeterson commented 2 years ago

@XLR8-0 Hi everyone. Thank you for submitting the sample and I apologize for the delay in the approval. I am working on trying to test the sample but I am getting the following error for the PowerShell sample. Can you please either provide some additional instructions and/or check for any bugs in that. Here is the error I am getting.

WARNING: Consider using -Interactive instead, which provides better functionality. See the documentation at https://pnp.github.io/powershell/cmdlets/Connect-PnPOnline.html#interactive-login-for-multi-factor-authentication Error occurred

-Derek

XLR8-0 commented 2 years ago

Hi @dcashpeterson, thank you for the reply. I just checked the code and found that the stated warning is coming. Could you please update the PowerShell code line 8 with Connect-PnPOnline -Url $siteUrl -Interactive or do you want me to update the same and push the code again?

dcashpeterson commented 2 years ago

@XLR8-0 Thanks for the update. I will get this reviewed as soon as I can.

dcashpeterson commented 2 years ago

@XLR8-0 Hi there. I am looking at this again and will approve it but the check check mark image is missing after the update. It is looking for something in the SiteAssets library. You might want to consider bundling that into the package in an update.

XLR8-0 commented 2 years ago

Thanks @dcashpeterson . I have updated that part and will push it sortly.