pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
111 stars 93 forks source link

BasicCard-Graph-UpcomingEvents: Error in Teams viva connections app #54

Closed jimmyalfSoleil closed 2 years ago

jimmyalfSoleil commented 2 years ago

Sample

Which sample are you having trouble with? BasicCard-Graph-UpcomingEvents PrimaryTextCard-Graph-UnreadEmails

They both works fine on a home site in SharePoint and Teams using a webbrowser. But when I add the viva connections teams app I get the error:

"Unable to retrieve Client Secret" for BasicCard-Graph-UpcomingEvents and PrimaryTextCard-Graph-UnreadEmails just says "Loading..."

Authors

Nick Brown (@techienickb) Zach Roberts (@ZachSPODev)

Expected or Desired Behavior

No errors in teams viva connection app.

Observed Behavior

What does it do? Throw an something went wrong error

Steps to Reproduce

Add viva connection app in teams

Environment Details (Development & Target environment)

Works in all browser but not in teams for windows and macOS. latest version of teams to this date.

Additional context

anoopt commented 2 years ago

@jimmyalfSoleil - Do you see this issue in the Teams mobile app as well? Maybe the thread here has some information that you might find useful.

jimmyalfSoleil commented 2 years ago

Yes, it's the samt error on mobile. Everything's works fine in our developer tenant though. Same issues as this https://github.com/SharePoint/sp-dev-docs/issues/7693

dcashpeterson commented 2 years ago

@techienickb @zachroberts8668 Can you please take a look at the related issues and see if there is anything we can do with your samples? Thanks, -Derek

techienickb commented 2 years ago

@techienickb @zachroberts8668 Can you please take a look at the related issues and see if there is anything we can do with your samples? Thanks, -Derek

When I tested my sample I didn't get this error in the teams mobile app. I'm not using any custom api's so client secret shouldn't be a thing. Retested and can confirm the newer version of teams mobile on android produces this error for graph connections.

@jimmyalfSoleil what version of the mobile teams app are you using?

Looks more like a configuration issue with Jimmy's tenant.

zachroberts8668 commented 2 years ago

@techienickb @zachroberts8668 Can you please take a look at the related issues and see if there is anything we can do with your samples? Thanks, -Derek

Investigating this now - will update when complete

jimmyalfSoleil commented 2 years ago

@techienickb I’m using Sessions-ID:5220bafd-733c-47af-947a-7e6b19acf37b Teams-version:1.077.2022063103 Appversion:0.2.202203100727-release-vcm-MarchT1 Användarring:general SDK-version:0.9.6

Tenant have the config accessTokenAcceptedVersion:1

techienickb commented 2 years ago

I can confirm that this error exists and it doesn't look to be isolated to this control, looks to be a wider SPFx issue. I get the same issue with my UnreadEmails ACE. Unable to access client secret.

@VesaJuvonen I may need you to do some digging. Mobile Teams app, SPFx's msGraphClientFactory isn't initializing correctly.

Tried with pnpjs (latest) as well and get the same results so looks to be wider. Also tried with SPFx 1.14.0 and no difference

techienickb commented 2 years ago

@jimmyalfSoleil the fix is in https://github.com/SharePoint/sp-dev-docs/issues/7963

dcashpeterson commented 2 years ago

@jimmyalfSoleil @techienickb is this ok to close.

techienickb commented 2 years ago

I think so. It was a spfx issue that looks to have been fixed niw

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Derek Cash-Peterson @.> Sent: Friday, August 26, 2022 1:38:28 PM To: pnp/sp-dev-fx-aces @.> Cc: Nick Brown @.>; Mention @.> Subject: Re: [pnp/sp-dev-fx-aces] BasicCard-Graph-UpcomingEvents: Error in Teams viva connections app (Issue #54)

@jimmyalfSoleilhttps://github.com/jimmyalfSoleil @techienickbhttps://github.com/techienickb is this ok to close.

— Reply to this email directly, view it on GitHubhttps://github.com/pnp/sp-dev-fx-aces/issues/54#issuecomment-1228437096, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADMXWFIPFQWF2X5EDR5S7WTV3C3EJANCNFSM5QMBOJEQ. You are receiving this because you were mentioned.Message ID: @.***>

dcashpeterson commented 2 years ago

Closed fixed in https://github.com/SharePoint/sp-dev-docs/issues/7963