pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
109 stars 92 forks source link

videoCard: media element in adaptive card doesn't show up in the mobile version of Viva Connections #57

Closed giuleon closed 2 years ago

giuleon commented 2 years ago

Sample

I'm referring to the following sample: https://github.com/pnp/sp-dev-fx-aces/tree/main/samples/ace-cardgallery/src/adaptiveCardExtensions/videocard

Expected or Desired Behavior

The media element should be available in teams mobile as well

Observed Behavior

I'm wondering if the media element (adaptive card) is supported in Teams mobile viva connections. It works fine in Teams desktop/web version.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Deploy the sample in the SP App Catalog
  2. Install the SPFx in the Home Site
  3. Add the adaptive card in the Viva Connection Dashboard
  4. Open Teams Viva Connections from a smartphone
anoopt commented 2 years ago

Adding a link to a related issue.

dcashpeterson commented 2 years ago

@anoopt you beat me to it. @giuleon There are some issues with different adaptive card components rendering in the mobile issue. This has been reported in SPDev docs. We can hold the issue here and once it is fixed we can update the sample.

TheRealBenForce commented 2 years ago

I'm experiencing this as well. Also, I have found that VIva Connections Card Designer action "Display a specified or current location" does not work on mobile, but I'm not sure where to open the issue. Tested with a specified location on both a Pixel and iPhone. Any suggestions or just piggy back on this one @dcashpeterson ?

anoopt commented 2 years ago

Hi @TheRealBenForce - I had seen that when SPFx 1.14 was released, in the release notes there was mention about the location action saying that

These new actions are only available in the browser currently. Viva Connections desktop and Viva Connections mobile support will be enabled later.

More details on the same can be found here.

The release notes do not specify a timeline on the availability of the location action in mobile. Let's keep an eye on the SPFx 1.15 launch to see if there will be any updates on the location action.

In case you want to know more details then you can log an issue/ask a question in the sp-dev-docs repository.

Hope this helps.

dcashpeterson commented 2 years ago

@TheRealBenForce The best place to report any bugs with SPFx is the SPFx Developer Docs repo. https://github.com/SharePoint/sp-dev-docs

As @anoopt mentioned the issue with the Video Card is already reported. If you are having an issue with mobile support for the Current Location I would post it there as well.

dcashpeterson commented 2 years ago

Closing this one as it relates more to SPFx and Teams Mobile rather than the samples.