search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
109 stars 92 forks source link

Added sample Public Holidays #92

Closed nanddeepn closed 2 years ago

nanddeepn commented 2 years ago
Q A
New sample? yes

What's in this Pull Request?

Added new ACE sample Public Holidays. This sample shows how to build an ACE with a card view and multiple quick views to display the public holidays for user based on their office location. Users can also use this ACE solution to update their office location.

Co-Authors: @ravi16a87, @SmitaNachan

dcashpeterson commented 2 years ago

@nanddeepn can you please take a look at this sample. When I configure it based on the instructions I get the following error. https://mytenant.sharepoint.com/_api/web/lists('87532e11-adcb-49db-82a8-1a17a6a1bc74')/getitems 500 error {"lang":"en-US","value":"One or more field types are not installed properly. Go to the list settings page to delete these fields."}}}

I followed the instructions on how to create the list. Not sure if this is an issue with the code or with the instructions. Can you please take a look. Also, does this need any API permissions, I didn't see any in the package-solution file.

nanddeepn commented 2 years ago

Hi @dcashpeterson

Thank you for noticing. It was my bad to forgot to include the Date column in the instructions. Apologies for the inconvenience. Can you please retest? Thank you.