search

pnp / sp-dev-fx-aces

Repository for the Microsoft Viva Connections Adaptive Card sample solutions from Microsoft and community.
https://aka.ms/viva/connections/extensibility
MIT License
109 stars 92 forks source link

Shared graph client (with batching) #97

Closed mgwojciech closed 1 year ago

mgwojciech commented 2 years ago
Q A
Bug fix? no
New feature? no
New sample? yes
Related issues?

What's in this Pull Request?

This is a sample how we can reuse graph client between ACEs from a different solutions. This can be quite handy especially if we implement batching strategy (as in this sample). Thanks to that requests from all ACEs can be batched together, which improves performance and overall end user experience

dcashpeterson commented 2 years ago

@mgwojciech Can you please check this? When I try to follow the ReadMe instructions in the Shared-Docs-ACE I cant do an NPM i I get the following error. npm ERR! code E404 npm ERR! 404 Not Found - GET https://registry.npmjs.org/graph-client-library - Not found npm ERR! 404 npm ERR! 404 'graph-client-library@0.0.1' is not in this registry.

Can you please assist with this? -Derek

mgwojciech commented 2 years ago

Oh...I forgot to add the info the You should npm link graph-client-library - this is a sp-library, I'll add the info to readme and push it during the weekend. Sorry for the issue

mgwojciech commented 1 year ago

Hi @dcashpeterson - sorry it took so long :) I added documentation about linking the graph-client-library