pnp / sp-dev-fx-controls-react

Reusable React controls for SPFx solutions
https://pnp.github.io/sp-dev-fx-controls-react/
MIT License
382 stars 379 forks source link

Image picker enhancements #1367

Open Moataz-Vodafone opened 1 year ago

Moataz-Vodafone commented 1 year ago

Site menu interface should match the way the OneDrive section displays folders. When you select the OneDrive section, folders are displayed using the yellow folder icon, but when you select the Site section, only a grey box is displayed.

Upload doesn't prompt with browser file picker when selected. When you click on Upload using the OOTB image picker, it displays a file picker without the user having to click the Choose file link first. From a link needs the instruction text updating, and doesn't have any placeholder text. OOTB there is "https://" as placeholder text, and different instructions are provided.

Selected text doesn't match site theme colour (our theme in the example screenshots uses red):

ghost commented 1 year ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

github-actions[bot] commented 1 year ago

Thank you for submitting your first issue to this project.

michaelmaillot commented 1 year ago

Hi @Moataz-Vodafone,

Sounds like interesting improvment ideas!

FYI regarding the selected text which doesn't match theme colour, this has been fixed with latest version:

image

Ateina commented 4 months ago

Hi @michaelmaillot I want to contribute to this issue. Could you please assign it me?

michaelmaillot commented 4 months ago

It's all yours 🙂