Module not found - Wrong @fluentui imports cause webpack build errors

hohenp commented 4 months ago

Version

Version: 3.17.0

Expected / Desired Behavior / Question

We are using the spfx-controls-react within a webpack project and would expect to build it without webpack errors.

Observed Behavior

We are using the spfx-controls-react within a webpack project. When we build the project we get several webpack errors like:

Steps to Reproduce

We could identify the used imports of the @fluentui package to cause that issue: You are using for example the following import: import { ActionButton, PrimaryButton } from "@fluentui/react/lib/components/Button"; The correct import would be: import { PrimaryButton } from '@fluentui/react/lib/Button'; as described on the fluent ui page

You can also check the export section of the @fluentui package.json file. There for example the button is declared as

"./lib/Button": {
      "types": "./lib/Button.d.ts",
      "import": "./lib/Button.js",
      "require": "./lib-commonjs/Button.js"
    },

so without the /components/ section of the import you are using.

For testing we fixed the wrong imports in the following files and that fixed all build errors we got

Could you please check all your imports of the @fluentui package?

Thanks Pascal

ghost commented 4 months ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

github-actions[bot] commented 4 months ago

Thank you for submitting your first issue to this project.

hohenp commented 3 months ago

Hello, could someone look into this?

joelfmrodrigues commented 3 months ago

@hohenp many thanks for reporting this issue. Would you be interested in submitting a PR with the required changes?

raclettierer commented 3 months ago

@joelfmrodrigues fix for the fluentui import are done and ready for review

raclettierer commented 2 months ago

@AJIXuMuK wo will approve PRs ? we still waiting on this change.

joelfmrodrigues commented 2 months ago

@hohenp the PR from @raclettierer is now merged. Would it be possible for you to test using the beta release please and let us know the outcome?

hohenp commented 2 months ago

Hi, I have tested the 3.18.0-beta.8771998 and can confirm that it works correct.

pnp / sp-dev-fx-controls-react