search

pnp / sp-dev-fx-controls-react

Reusable React controls for SPFx solutions
https://pnp.github.io/sp-dev-fx-controls-react/
MIT License
383 stars 380 forks source link

Fix for #1775 and #1760 #1781

Open wuxiaojun514 opened 7 months ago

wuxiaojun514 commented 7 months ago
Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1775 #1760

What's in this Pull Request?

This pull request is to fix two issues on required field validation issues in Dynamic Form control Dynamic Form has done huge refactoring on version 3.17. See pull request 1672 for detail

The root cause of issue #1760 is due to the initial value of newValue has been changed from "null" to "undefined". So I modified the related code to "undefined" as well.

Regarding #1775 , now changedValue won't use loaded item's value as initial value. So I added another check to compare with value when there is no new value on this field.

6gal6ler6 commented 7 months ago

@wuxiaojun514

Thanks for taking care of this issue!!!

devspfx commented 6 months ago

When will be this fix available? When we will have a new release?

joelfmrodrigues commented 4 months ago

Waiting for #1726

devspfx commented 1 month ago

@joelfmrodrigues any news about this issue? We hope to have a resolution