search

pnp / sp-dev-fx-controls-react

Reusable React controls for SPFx solutions
https://pnp.github.io/sp-dev-fx-controls-react/
MIT License
380 stars 380 forks source link

Module not found - Wrong @fluentui imports cause webpack build errors #1763 #1793

Closed raclettierer closed 2 months ago

raclettierer commented 3 months ago
Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1763

What's in this Pull Request?

(https://github.com/pnp/sp-dev-fx-controls-react/issues/1763)

joelfmrodrigues commented 2 months ago

@raclettierer I'm sorry for the delay on this, has been flagged on my inbox as to-do since you created the PR, but I was busy with the release of a baby 😄 We will try to review soon

joelfmrodrigues commented 2 months ago

@raclettierer I have updated the target branch to the dev branch. Can you please get the latest version from dev and resolve the conflicts on the PR?

raclettierer commented 2 months ago

@joelfmrodrigues : done

joelfmrodrigues commented 2 months ago

@raclettierer many thanks, this is now merged