Carousel: make buttonLocation and buttonDisplay optional, add contentHeight property - Githubissues

pnp / sp-dev-fx-controls-react

Reusable React controls for SPFx solutions

https://pnp.github.io/sp-dev-fx-controls-react/

MIT License

380 stars 380 forks source link

Carousel: make buttonLocation and buttonDisplay optional, add contentHeight property #1801

Closed AJIXuMuK closed 2 months ago

AJIXuMuK commented 2 months ago

Q	A
Bug fix?	[ ]
New feature?	[x]
New sample?	[ ]
Related issues?	no

What's in this Pull Request?

The PR contains changes to the Carousel component:

buttonLocation is now optional. Default value is center.
buttonDisplay is now optional. Default value is block.
new property contentHeight is added. It can be used instead of contentContainerStyle to specify the height for the slide's content.

Guidance

You can delete this section when you are submitting the pull request.
Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
Please target your PR to dev branch.