search

pnp / sp-dev-fx-controls-react

Reusable React controls for SPFx solutions
https://pnp.github.io/sp-dev-fx-controls-react/
MIT License
383 stars 380 forks source link

Issue 1250 #1839

Closed DevPio closed 1 month ago

DevPio commented 3 months ago
Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

1250

Gravando 2024-06-22 054402

Gravando 2024-06-22 054942

This PR introduces the ability to clear the selection in the SitePicker control when in single selection mode. It includes a custom renderer for the chevron icon, which now displays a "Cancel" icon alongside the chevron when an item is selected. Clicking the "Cancel" icon clears the current selection. The "Cancel" icon is only shown when an item is selected, ensuring a clean UI when there is no selection. These changes improve the user experience by making selection management more intuitive.

michaelmaillot commented 1 month ago

Hi @DevPio,

Nice improvment, thanks! I think it's ok for this to be merged, but first: would you mind updating your branch to get latest version?

DevPio commented 1 month ago

@michaelmaillot done!

michaelmaillot commented 1 month ago

Merged manually, thank you!