search

pnp / sp-dev-fx-controls-react

Reusable React controls for SPFx solutions
https://pnp.github.io/sp-dev-fx-controls-react/
MIT License
380 stars 379 forks source link

RichText: quill:toolbar error in a SPFx extension / Dialog #494

Closed Louren closed 11 months ago

Louren commented 4 years ago

Category

[ ] Enhancement [X] Bug [ ] Question

Version

Please specify what version of the library you are using: [ ]

Expected / Desired Behavior / Question

We're using the RichText control in a Dialog in a SharePoint ListView command set to allow editing of list items in a customized way.

Observed Behavior

Upon loading, the console error shows op: quill:toolbar Container required for toolbar

Steps to Reproduce

I can imagine this control wasn't developed with dialogs in mind (al references I see are from a webpart).

The error seems to be that Quill doesn't know where to load the toolbar. I can see that an element is (being) created (refer to screenshot below, #toolbar_9f90c055-9974-4327-8b32-c4ccb72785a4, but that it apparently can't be found (this is also according to quill source). Indeed, I can't find the element in the DOM.

image

Maybe relevant (and a difference between webparts and dialog-based plugins) is that the dialog is not yet shown (element not mounted). If this is indeed related to the error, than this might be a problem that other dialog-users will face as well?

I look forward to reading any suggestions!

ghost commented 4 years ago

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

github-actions[bot] commented 4 years ago

Thank you for submitting your first issue to this project.

Louren commented 4 years ago

Hello, is there anything we can do to help triage this issue?

Katli95 commented 3 years ago

Yep, facing the same issue now when using in dialog (SPFx ListViewCommandSet Extension). Repro steps as original post, does anyone have any ideas as to what the issue might be?

michaelmaillot commented 1 year ago

Hi everyone,

I've tested the RichText in latest version (3.15.0) within a OUIFR Dialog and it actually works (display, update, right panel,...).

Can you confirm it on your side?

Katli95 commented 11 months ago

I'm sorry I'm afraid I'm not working with SPFx religiously these days 😅 Props for pruning old tickets tho! ✌️

ghost commented 11 months ago

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within next 7 days of this comment. Thank you for your contributions to SharePoint Developer activities.

ghost commented 11 months ago

Closing issue due no response from original author. If this issue is still occurring, please open a new issue with additional details. Notice that if you have included another related issue as additional comment on this, please open that also as separate issue, so that we can track it independently.